Threads with friends#377
Conversation
f77626b to
2eda160
Compare
|
Love the work done here to add users without pinging them! 💚 |
|
It's been so longgggg. I forgottennn. I apologise for making it confusing |
|
I think since the underlying logic function now accepts either object type we can unify it to a single command. If you resolve all the other comments I'll be happy to approve without this change and leave it to see how it gets used and whether it does need changing. |
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new configuration option to automatically add the committee to threads and a new cog that implements commands for adding users or roles to threads and channels.
- Added a configuration setting in config.py for AUTO_ADD_COMMITTEE_TO_THREADS.
- Implemented the AddUsersToThreadsAndChannelsCommandCog with associated slash commands and autocompletion functions.
- Updated the cog initializer in cogs/init.py to include the new cog.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config.py | Added a new environment variable handler for AUTO_ADD_COMMITTEE_TO_THREADS. |
| cogs/add_users_to_threads_and_channels.py | New cog implementing commands to add users/roles to threads and channels. |
| cogs/init.py | Updated to include the new AddUsersToThreadsAndChannelsCommandCog. |
Comments suppressed due to low confidence (1)
cogs/add_users_to_threads_and_channels.py:198
- [nitpick] The parameter name 'user_id_str' might be misleading since it expects a string representation of a user ID; consider renaming it to something that more clearly reflects its purpose, such as 'user_id'.
parameter_name="user_id_str",
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>


couldn't think of a good name for the cog or the command so open to suggestions