Skip to content

Threads with friends#377

Merged
MattyTheHacker merged 62 commits intomainfrom
threads-with-friends
Mar 31, 2025
Merged

Threads with friends#377
MattyTheHacker merged 62 commits intomainfrom
threads-with-friends

Conversation

@MattyTheHacker
Copy link
Copy Markdown
Member

couldn't think of a good name for the cog or the command so open to suggestions

@MattyTheHacker MattyTheHacker self-assigned this Dec 20, 2024
@MattyTheHacker MattyTheHacker added the enhancement New feature or request label Dec 20, 2024
Comment thread cogs/thread_friends.py Outdated
Comment thread cogs/thread_friends.py Outdated
@CarrotManMatt
Copy link
Copy Markdown
Member

Love the work done here to add users without pinging them! 💚

Comment thread cogs/thread_friends.py Outdated
Comment thread cogs/thread_friends.py Outdated
Comment thread cogs/thread_friends.py Outdated
@MattyTheHacker
Copy link
Copy Markdown
Member Author

MattyTheHacker commented Mar 30, 2025

that accepts one or more members or roles, then acts accordingly.

b4d5cab3-efb4-4ae3-b54f-b399824753df

@MattyTheHacker
Copy link
Copy Markdown
Member Author

I still believe it would be preferable to combine these two separate commands into a single one

image

@CarrotManMatt
Copy link
Copy Markdown
Member

CarrotManMatt commented Mar 30, 2025

It's been so longgggg. I forgottennn. I apologise for making it confusing

@CarrotManMatt
Copy link
Copy Markdown
Member

I think since the underlying logic function now accepts either object type we can unify it to a single command. If you resolve all the other comments I'll be happy to approve without this change and leave it to see how it gets used and whether it does need changing.

Comment thread config.py Outdated
Comment thread cogs/add_users_to_threads_and_channels.py Outdated
MattyTheHacker and others added 5 commits March 30, 2025 21:06
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new configuration option to automatically add the committee to threads and a new cog that implements commands for adding users or roles to threads and channels.

  • Added a configuration setting in config.py for AUTO_ADD_COMMITTEE_TO_THREADS.
  • Implemented the AddUsersToThreadsAndChannelsCommandCog with associated slash commands and autocompletion functions.
  • Updated the cog initializer in cogs/init.py to include the new cog.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
config.py Added a new environment variable handler for AUTO_ADD_COMMITTEE_TO_THREADS.
cogs/add_users_to_threads_and_channels.py New cog implementing commands to add users/roles to threads and channels.
cogs/init.py Updated to include the new AddUsersToThreadsAndChannelsCommandCog.
Comments suppressed due to low confidence (1)

cogs/add_users_to_threads_and_channels.py:198

  • [nitpick] The parameter name 'user_id_str' might be misleading since it expects a string representation of a user ID; consider renaming it to something that more clearly reflects its purpose, such as 'user_id'.
        parameter_name="user_id_str",

Comment thread cogs/add_users_to_threads_and_channels.py Outdated
Comment thread cogs/add_users_to_threads_and_channels.py
Comment thread cogs/add_users_to_threads_and_channels.py Outdated
Comment thread cogs/add_users_to_threads_and_channels.py Outdated
MattyTheHacker and others added 2 commits March 31, 2025 18:17
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
Co-authored-by: Matt Norton <matt@carrotmanmatt.com>
@MattyTheHacker MattyTheHacker merged commit f49bbb6 into main Mar 31, 2025
9 checks passed
@MattyTheHacker MattyTheHacker deleted the threads-with-friends branch March 31, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants