Problem: components can't distinguish custom events#677
Open
yrashk wants to merge 1 commit intoArthurSonzogni:mainfrom
Open
Problem: components can't distinguish custom events#677yrashk wants to merge 1 commit intoArthurSonzogni:mainfrom
yrashk wants to merge 1 commit intoArthurSonzogni:mainfrom
Conversation
Owner
|
Hello @yrashk, I was thinking developers would be able to use: Event Event::Special(std::string input)directly. For instance: Retrospectively, What do you think. Does this solve your need? Note: To make your patch to work, |
yrashk
force-pushed
the
event-custom-tag
branch
2 times, most recently
from
6bd9ddc to
3d84e96
Compare
Author
|
Thank you! I was thinking of |
They all look the same, which means they would have to check or poll all potential sources of change. Solution: make custom events take an integer tag I've kept the backwards compatibility by using `-1` for the default custom event (`Event::Custom`).
Author
|
I've also updated this PR to pass the tests |
ArthurSonzogni
force-pushed
the
main
branch
5 times, most recently
from
f353474 to
c5357ac
Compare
ArthurSonzogni
force-pushed
the
main
branch
2 times, most recently
from
3bdbccd to
11f7132
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They all look the same, which means they would have to check or poll all potential sources of change.
Solution: make custom events take an integer tag
I've kept the backwards compatibility by using
-1for the default custom event (Event::Custom).Discussion: #676