Conversation
…tool residue
The pt-br localization of 10_InsertionSort/InsertionSort.sol had a JavaScript
translation-tool fragment in place of the ifElseTest function body:
if (text.includes('zh')) {
text = translate(text, 'zh', 'pt-br');
} else {
text = text;
}
This is not valid Solidity and prevented the contract from compiling. Replace
it with the correct ifElseTest(uint256 _number) function, matching the root
10_InsertionSort/InsertionSort.sol and the pt-br readme code block.
Diff (ignoring comments) between root and pt-br InsertionSort.sol is now empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
The pt-br localization of
Languages/pt-br/10_InsertionSort/InsertionSort.solcontains a JavaScript translation-tool fragment where theifElseTestfunction body should be. The stray lines are not valid Solidity, and the contract does not compile in its current form:This almost certainly came from an automated translation pass that did not skip code blocks.
This PR restores the
ifElseTest(uint256 _number)function, matching the root10_InsertionSort/InsertionSort.soland the code block already documented inLanguages/pt-br/10_InsertionSort/readme.md:After the fix, the diff (ignoring comments) between the root and pt-br
InsertionSort.solis empty, so the localized contract is functionally identical to the canonical one.Scope
Languages/pt-br/10_InsertionSort/InsertionSort.sol+5 / -5lines (the JS fragment was 5 non-comment lines; theifElseTestbody is also 5 lines plus closing braces).Type of PR
How to verify
should succeed (it currently fails with
ParserErroron thetext.includes('zh')line).