fix: preserve chat history when background summarization fails - #5689
Open
gary23w wants to merge 1 commit into
Open
fix: preserve chat history when background summarization fails#5689gary23w wants to merge 1 commit into
gary23w wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When background chat summarization raises
ValueError, the worker reports a warning but leavessummarized_done_messagesempty. On joining the worker,summarize_end()then replaces unchanged, intact chat history with that empty list.Retain the original snapshot as the fallback on failure. The existing comparison still prevents replacement if history changed during summarization, and a later successful summary can still replace matching history. No changes to summarization prompts, model selection, or retry policy.
Verification
[].python -m pytest tests/basic/test_coder.py tests/basic/test_history.py -q: 49 passed, 29 subtests passed on Windows. Temporary Git fixture commits used process-localcommit.gpgsign=false; no user Git configuration was changed.git diff --checkpass.AI assistance: Codex helped identify and reproduce the defect, implement the one-line fallback, independently review the diff, and run tests/checks.