fix: defer history mkdir warning until console exists - #5672
Open
Alphaxiaoteng wants to merge 1 commit into
Open
fix: defer history mkdir warning until console exists#5672Alphaxiaoteng wants to merge 1 commit into
Alphaxiaoteng wants to merge 1 commit into
Conversation
InputOutput called tool_warning during __init__ before self.console was created, causing AttributeError when history directory creation failed. Fixes Aider-AI#5669.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__calledtool_warningbeforeself.consoleexisted, raisingAttributeErrorand aborting startup.Path.mkdirto fail and asserts construction succeeds withinput_history_filecleared.Test plan
pytest tests/basic/test_io_history_mkdir.py -q→ 1 passedconsoleis available after the failed mkdir pathMade with Cursor