Use documented MFCC output formats in Python example - #341
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Use documented MFCC output formats in Python example#341sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #279
Summary
2^23divisor2^7divisorContext
arm_mfcc_q31andarm_mfcc_q15return q8.23 and q8.7 values respectively. The example previously converted them as ordinary Q31 and Q15 values and multiplied byFFTSize. That gives the expected scale for the current 256-point test only because both output formats have eight integer bits. A different FFT length would scale the displayed MFCC values incorrectly.This follows the maintainer's format clarification in #279 and makes the example match the function documentation.
Validation
python -m py_compile PythonWrapper/examples/testmfcc.pygit diff --checkThe full example test was not run because the compiled
cmsisdspextension modules are unavailable in the local environment.