Prevent Helium complex multiplication saturation - #340
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The Helium implementations combined
vqdmlsdhqandvqdmladhxqon full-scale inputs. A real or imaginary component above the 1.15 or 1.31 intermediate range could therefore saturate before the final two-bit downshift, even though the documented 3.13 and 3.29 outputs can represent the result.Scaling each input by one bit keeps the saturating intermediate in range. Removing the result downshift preserves the existing output scale.
Fixes #47
Validation
git diff --checkpython -m py_compile Testing/PatternGeneration/ComplexMaths.pyTesting/desc.txtand generated the full embedded test description-Wall -Wextra -WerrorNot run
Testing/cmsis_build/runall.pywas not run because this environment does not provide the CMSIS Build tools or an Arm Virtual Hardware target.