Remove parity branches from arm_sqrt_q15 - #339
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Issue #9 proposes two independent improvements to
arm_sqrt_q15. One is to make the normalization shift even before it is used, which removes parity checks before and after the inverse-square-root calculation. The other is a wider internal format and new lookup table for greater precision.This change implements only the branch-removal optimization. Rounding an odd normalization shift down to the preceding even value is exactly what both existing odd branches already do, so the numerical behavior remains unchanged.
This addresses the normalization-shift portion of #9.
Validation
git diff --check-Wall -Wextra -Werror-O0and-O3The full repository test suite was not run.