Document in-place complex magnitude support - #335
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numSamplesinput elementsContext
The maintainer confirmed in #110 that complex magnitude can be processed in place, but the public documentation does not state this. The missing guarantee can cause callers to allocate an unnecessary output buffer.
This addresses the confirmed complex-magnitude portion of #110. It does not make any claim about the filtering functions discussed in that issue.
Validation
git diff --check-Wall -Wextra -WerrorpSrc == pDstin plain scalar and loop-unrolled builds; all five-sample outputs matched byte for byteDocumentation-only change. The full repository test suite was not run.