Decouple floating-point loop unrolling from DSP extensions - #332
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Decouple floating-point loop unrolling from DSP extensions#332sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arm_conv_f32,arm_conv_partial_f32,arm_correlate_f32, andarm_correlate_f16usingARM_MATH_LOOPUNROLLContext
ARM_MATH_DSPrepresents integer DSP extensions and does not determine whether these floating-point implementations can use manual loop unrolling. The existing outer guards therefore preventARM_MATH_LOOPUNROLLfrom selecting the unrolled scalar path unlessARM_MATH_DSPis also defined.This change makes the outer selection consistent with the loop-unroll option discussed in #193 while leaving the algorithms unchanged.
Fixes #193.
Validation
git diff --check-Wall -Wextra -Werror -Wmissing-prototypesunder:ARM_MATH_LOOPUNROLLARM_MATH_DSPwithout loop unrollingARM_MATH_LOOPUNROLLwithARM_MATH_AUTOVECTORIZEThe CMake-based repository suite was not run because CMake is unavailable in the local environment.