MethodFinder : Add unit tests for String.TrimEnd()

Author: StefH

src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs

@@ -168,7 +168,7 @@ bool IsApplicable(MethodData method, Expression[] args)
 
                         for (int j = method.Parameters.Length - 1; j < args.Length; j++)
                         {
-                            Expression promoted = this._parsingConfig.ExpressionPromoter.Promote(args[j], paramElementType, false, method.MethodBase.DeclaringType != typeof(IEnumerableSignatures));
+                            Expression promoted = _parsingConfig.ExpressionPromoter.Promote(args[j], paramElementType, false, method.MethodBase.DeclaringType != typeof(IEnumerableSignatures));
                             if (promoted == null)
                             {
                                 return false;
@@ -190,7 +190,7 @@ bool IsApplicable(MethodData method, Expression[] args)
                         return false;
                     }
 
-                    Expression promoted = this._parsingConfig.ExpressionPromoter.Promote(args[i], pi.ParameterType, false, method.MethodBase.DeclaringType != typeof(IEnumerableSignatures));
+                    Expression promoted = _parsingConfig.ExpressionPromoter.Promote(args[i], pi.ParameterType, false, method.MethodBase.DeclaringType != typeof(IEnumerableSignatures));
                     if (promoted == null)
                     {
                         return false;
@@ -205,13 +205,13 @@ bool IsApplicable(MethodData method, Expression[] args)
 
         bool IsBetterThan(Expression[] args, MethodData first, MethodData second)
         {
-            bool better = false;
-            //If args count is 0, than parametereless method is better than method method with parameters
-			if (args.Length == 0)
+            // If args count is 0 -> parametereless method is better than method method with parameters
+            if (args.Length == 0)
             {
-                better = (first.Parameters.Length == 0) && (second.Parameters.Length != 0);
-            }			
-			
+                return first.Parameters.Length == 0 && second.Parameters.Length != 0;
+            }
+
+            bool better = false;
             for (int i = 0; i < args.Length; i++)
             {
                 CompareConversionType result = CompareConversions(args[i].Type, first.Parameters[i].ParameterType, second.Parameters[i].ParameterType);

test/System.Linq.Dynamic.Core.Tests/DynamicExpressionParserTests.cs

@@ -1230,5 +1230,33 @@ public void DynamicExpressionParser_ParseLambda_ActionDelegate_VoidMethodCallExp
             // Assert
             dataSource.Name.Should().NotBeNullOrEmpty();
         }
+
+        [Fact]
+        public void DynamicExpressionParser_ParseLambda_String_TrimEnd_0_Parameters()
+        {
+            // Act
+            var expression = DynamicExpressionParser.ParseLambda<string, bool>(new ParsingConfig(), false, "TrimEnd().EndsWith(@0)", "test");
+
+            var @delegate = expression.Compile();
+
+            var result = (bool) @delegate.DynamicInvoke("This is a test  ");
+
+            // Assert
+            result.Should().BeTrue();
+        }
+
+        [Fact]
+        public void DynamicExpressionParser_ParseLambda_String_TrimEnd_1_Parameter()
+        {
+            // Act
+            var expression = DynamicExpressionParser.ParseLambda<string, bool>(new ParsingConfig(), false, "TrimEnd('.').EndsWith(@0)", "test");
+
+            var @delegate = expression.Compile();
+
+            var result = (bool)@delegate.DynamicInvoke("This is a test...");
+
+            // Assert
+            result.Should().BeTrue();
+        }
     }
 }