UnitTests: add and use SkipIfGitHubActionsAttribute (#693)

* IsRunningOnGitHubActions

* ...

* last?

* ChatGPT

Author: StefH

.github/workflows/ci.yml

@@ -6,6 +6,9 @@ jobs:
   build:
     runs-on: windows-2022
 
+    env:
+      IsRunningOnGitHubActions: 'true'
+
     steps:  
     - uses: actions/checkout@v2
 

System.Linq.Dynamic.Core.sln.DotSettings

@@ -4,4 +4,5 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=UTC/@EntryIndexedValue">UTC</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=WASM/@EntryIndexedValue">WASM</s:String>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Formattable/@EntryIndexedValue">True</s:Boolean>
-	<s:Boolean x:Key="/Default/UserDictionary/Words/=renamer/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=renamer/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Xunit/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

test/EntityFramework.DynamicLinq.Tests.net452/EntityFramework.DynamicLinq.Tests.net452.csproj

@@ -13,7 +13,7 @@
     <AssemblyName>EntityFramework.DynamicLinq.Tests.net452</AssemblyName>
     <TargetFrameworkVersion>v4.5.2</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
-      <LangVersion>10</LangVersion>
+    <LangVersion>10</LangVersion>
     <NuGetPackageImportStamp>
     </NuGetPackageImportStamp>
   </PropertyGroup>
@@ -288,6 +288,9 @@
     <Compile Include="..\System.Linq.Dynamic.Core.Tests\QueryableTests.Is,OfType,As,Cast.cs">
       <Link>QueryableTests.Is,OfType,As,Cast.cs</Link>
     </Compile>
+    <Compile Include="..\System.Linq.Dynamic.Core.Tests\TestHelpers\DisplayTestMethodNameAttribute.cs">
+      <Link>TestHelpers\DisplayTestMethodNameAttribute.cs</Link>
+    </Compile>
     <Compile Include="..\System.Linq.Dynamic.Core.Tests\TestHelpers\ExpressionString.cs">
       <Link>TestHelpers\ExpressionString.cs</Link>
     </Compile>

test/System.Linq.Dynamic.Core.Tests/DynamicClassTest.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using System.Dynamic;
+using System.Linq.Dynamic.Core.Tests.TestHelpers;
 using FluentAssertions;
 using Newtonsoft.Json;
 using Xunit;
@@ -156,8 +157,7 @@ public void DynamicClass_GetRuntimeType()
         typeOf.ToString().Should().Be("System.Linq.Dynamic.Core.DynamicClass"); // ???
     }
 
-    // [Fact(Skip = "fails on CI build GitHub Actions")]
-    [Fact]
+    [SkipIfGitHubActions]
     public void DynamicClassArray()
     {
         // Arrange
@@ -189,7 +189,7 @@ public void DynamicClassArray()
         isValid.Should().BeTrue();
     }
 
-    [Fact]
+    [SkipIfGitHubActions]
     public void DynamicClassArray_Issue593_Fails()
     {
         // Arrange
@@ -221,7 +221,7 @@ public void DynamicClassArray_Issue593_Fails()
         isValid.Should().BeFalse(); // This should actually be true, but fails. For solution see Issue593_Solution1 and Issue593_Solution2.
     }
 
-    [Fact]
+    [SkipIfGitHubActions]
     public void DynamicClassArray_Issue593_Solution1()
     {
         // Arrange
@@ -253,7 +253,7 @@ public void DynamicClassArray_Issue593_Solution1()
         isValid.Should().BeTrue();
     }
 
-    [Fact]
+    [SkipIfGitHubActions]
     public void DynamicClassArray_Issue593_Solution2()
     {
         // Arrange

test/System.Linq.Dynamic.Core.Tests/TestHelpers/ExpressionString.cs

@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace System.Linq.Dynamic.Core.Tests.TestHelpers
+namespace System.Linq.Dynamic.Core.Tests.TestHelpers
 {
     public static class ExpressionString
     {
@@ -17,4 +11,4 @@ public static string NullableConversion(string convertedExpr)
 #endif
         }
     }
-}
+}

test/System.Linq.Dynamic.Core.Tests/TestHelpers/SkipIfGitHubActionsAttribute.cs

@@ -0,0 +1,33 @@
+using Xunit;
+
+namespace System.Linq.Dynamic.Core.Tests.TestHelpers;
+
+internal class SkipIfGitHubActionsAttribute : FactAttribute
+{
+    public SkipIfGitHubActionsAttribute()
+    {
+        if (IsRunningOnGitHubActions())
+        {
+            // ReSharper disable once VirtualMemberCallInConstructor
+            Skip = "This test is skipped on GitHub Actions";
+        }
+    }
+
+    /// <summary>
+    /// According to ChatGPT:
+    /// 
+    /// The GITHUB_ACTIONS environment variable is not officially documented by GitHub, but it is mentioned in the GitHub Actions documentation in a few places. Here are some relevant links:
+    /// [Context and expression syntax for GitHub Actions](https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context) - This page lists all the GitHub-specific context variables that are available in a GitHub Actions workflow, including GITHUB_ACTIONS.
+    /// [Virtual environments for GitHub-hosted runners](https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#virtual-environments-for-github-hosted-runners) - This page explains the environment variables that are available on GitHub-hosted runners, including GITHUB_ACTIONS.
+    /// [Actions virtual environments](https://github.com/actions/virtual-environments#operating-systems) - This page provides more information about the virtual environments used by GitHub Actions, including the operating systems and software versions used on each environment.
+    /// </summary>
+    private static bool IsRunningOnGitHubActions()
+    {
+        return GetBool("GITHUB_ACTIONS") || GetBool("IsRunningOnGitHubActions");
+    }
+
+    private static bool GetBool(string variable)
+    {
+        return bool.TryParse(Environment.GetEnvironmentVariable(variable), out var value) && value;
+    }
+}