upgrade ruby to 4.0.5 (#2065)

* upgrade ruby to 4.0.5
* use local variable for CDR string_filters

Author: dmitry-sinina

.rubocop.yml

@@ -8,7 +8,7 @@ plugins:
 AllCops:
   DisplayCopNames: true
   DisabledByDefault: true
-  TargetRubyVersion: 3.3
+  TargetRubyVersion: 4.0
   Exclude:
     - 'db/migrate/**/*'
     - 'db/cdr_migrate/**/*'

.ruby-version

@@ -1 +1 @@
-3.4.10
+4.0.5

Gemfile

@@ -145,6 +145,9 @@ gem 'webrick', require: false
 
 gem 'cronex'
 
+# Ruby 4.0 dropped cgi from the default gems (only cgi/escape survives), but
+# click_house's logging middleware still calls CGI.parse and upstream is unmaintained.
+gem 'cgi'
 gem 'click_house'
 
 gem 'aws-sdk-s3', require: false

Gemfile.lock

@@ -267,6 +267,7 @@ GEM
     capybara-screenshot (1.0.27)
       capybara (>= 1.0, < 4)
       launchy
+    cgi (0.5.2)
     click_house (2.1.2)
       activesupport
       faraday (>= 1.7, < 3)
@@ -525,7 +526,7 @@ GEM
     matrix (0.4.3)
     mini_mime (1.1.5)
     mini_portile2 (2.8.9)
-    mini_racer (0.21.2)
+    mini_racer (0.21.4)
       libv8-node (~> 24.12.0.1)
     minitest (6.0.6)
       drb (~> 2.0)
@@ -869,7 +870,7 @@ GEM
       logger
       prism (>= 1.6.0)
       tsort
-    rbtree (0.4.6)
+    rbtree (0.4.7)
     rchardet (1.10.2)
     rdoc (8.0.0)
       erb
@@ -1084,6 +1085,7 @@ DEPENDENCIES
   capybara
   capybara-screenshot
   capybara_active_admin!
+  cgi
   click_house
   config
   cronex

app/admin/cdr/cdrs.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 # ActiveAdmin's default string predicates, with "equals" first instead of "contains".
-STRING_FILTERS = %i[eq cont start end].freeze
+# A local, not a constant: app/admin is reloaded on every delayed_job poll in
+# development, and a top-level constant warns "already initialized" on each reload.
+string_filters = %i[eq cont start end].freeze
 
 ActiveAdmin.register Cdr::Cdr, as: 'CDR' do
   menu parent: 'CDR', priority: 95, label: 'CDR history'
@@ -85,9 +87,9 @@ def try_cdr_replica(&)
                           label: 'Customer Auth',
                           scope: -> { CustomersAuth.order(:name) },
                           path: '/customers_auths/search'
-  filter :src_prefix_routing, filters: STRING_FILTERS
+  filter :src_prefix_routing, filters: string_filters
   filter :src_area, collection: proc { Routing::Area.select(%i[id name]) }, input_html: { class: 'tom-select' }
-  filter :dst_prefix_routing, filters: STRING_FILTERS
+  filter :dst_prefix_routing, filters: string_filters
   filter :dst_area, collection: proc { Routing::Area.select(%i[id name]) }, input_html: { class: 'tom-select' }
 
   country_filter :src_country_id_eq, label: 'SRC Country'
@@ -154,47 +156,47 @@ def try_cdr_replica(&)
            multiple: true,
            'data-path': '/disconnect_codes/search'
          }
-  filter :internal_disconnect_reason, filters: STRING_FILTERS
+  filter :internal_disconnect_reason, filters: string_filters
   filter :lega_disconnect_code
-  filter :lega_disconnect_reason, filters: STRING_FILTERS
+  filter :lega_disconnect_reason, filters: string_filters
   filter :lega_q850_cause_eq, label: 'LegA Q.850 cause', as: :select, collection: System::Q850::CAUSES.invert, input_html: { class: 'tom-select' }
 
   filter :legb_disconnect_code
-  filter :legb_disconnect_reason, filters: STRING_FILTERS
+  filter :legb_disconnect_reason, filters: string_filters
   filter :legb_q850_cause_eq, label: 'LegB Q.850 cause', as: :select, collection: System::Q850::CAUSES.invert, input_html: { class: 'tom-select' }
 
-  filter :src_prefix_in, filters: STRING_FILTERS
-  filter :dst_prefix_in, filters: STRING_FILTERS
-  filter :src_prefix_out, filters: STRING_FILTERS
-  filter :dst_prefix_out, filters: STRING_FILTERS
-  filter :lrn, filters: STRING_FILTERS
-  filter :diversion_in, filters: STRING_FILTERS
-  filter :diversion_out, filters: STRING_FILTERS
-  filter :src_name_in, filters: STRING_FILTERS
-  filter :src_name_out, filters: STRING_FILTERS
+  filter :src_prefix_in, filters: string_filters
+  filter :dst_prefix_in, filters: string_filters
+  filter :src_prefix_out, filters: string_filters
+  filter :dst_prefix_out, filters: string_filters
+  filter :lrn, filters: string_filters
+  filter :diversion_in, filters: string_filters
+  filter :diversion_out, filters: string_filters
+  filter :src_name_in, filters: string_filters
+  filter :src_name_out, filters: string_filters
   filter :node, input_html: { class: 'tom-select' }
   filter :pop, input_html: { class: 'tom-select' }
-  filter :local_tag, filters: STRING_FILTERS
-  filter :legb_local_tag, filters: STRING_FILTERS
-  filter :orig_call_id, as: :string, filters: STRING_FILTERS
-  filter :term_call_id, as: :string, filters: STRING_FILTERS
+  filter :local_tag, filters: string_filters
+  filter :legb_local_tag, filters: string_filters
+  filter :orig_call_id, as: :string, filters: string_filters
+  filter :term_call_id, as: :string, filters: string_filters
   filter :routing_attempt
   filter :customer_price
   filter :vendor_price
   filter :profit
   filter :routing_delay
   filter :pdd
   filter :rtt
-  filter :p_charge_info_in, filters: STRING_FILTERS
+  filter :p_charge_info_in, filters: string_filters
   filter :uuid_equals, label: 'UUID'
   filter :auth_orig_ip_covers,
          as: :string,
          input_html: { class: 'search_filter_string' },
          label: I18n.t('activerecord.attributes.cdr.auth_orig_ip')
-  filter :sign_orig_ip, filters: STRING_FILTERS
-  filter :sign_orig_local_ip, filters: STRING_FILTERS
-  filter :sign_term_local_ip, filters: STRING_FILTERS
-  filter :sign_term_ip, filters: STRING_FILTERS
+  filter :sign_orig_ip, filters: string_filters
+  filter :sign_orig_local_ip, filters: string_filters
+  filter :sign_term_local_ip, filters: string_filters
+  filter :sign_term_ip, filters: string_filters
   filter :customer_auth_external_type_eq, as: :string, label: 'CUSTOMER AUTH EXTERNAL TYPE'
   filter :lega_ss_status_id_eq, label: 'LegA SS status', as: :select, collection: Cdr::Cdr::SS_STATUSES.invert, input_html: { class: 'tom-select' }
   filter :legb_ss_status_id_eq, label: 'LegB SS status', as: :select, collection: Cdr::Cdr::SS_STATUSES.invert, input_html: { class: 'tom-select' }

bin/prometheus_exporter

@@ -8,7 +8,6 @@
 # this file is here to facilitate running it.
 #
 
-require 'pathname'
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', Pathname.new(__FILE__).realpath)
 
 bundle_binstub = File.expand_path('bundle', __dir__)

spec/features/ajax_filters_spec.rb

@@ -34,7 +34,7 @@
       customer_filter.dropdown.select_option(customer.display_name)
       page.find('.filter_form input[type=submit]').click
 
-      expect(CGI.unescape(page.current_url)).to include("q[customer_id_eq]=#{customer.id}")
+      expect(Rack::Utils.unescape(page.current_url)).to include("q[customer_id_eq]=#{customer.id}")
       # expect(page).to have_field_tom_select('Customer', with: customer.display_name)
       parent = find('.filter_form')
       new_customer_filter = Section::TomSelect.by_label('CUSTOMER', exact: true, parent:)