Merge pull request #422 from yarpc/dev

Release v0.24.0

Author: pulkit4tech

CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+# 0.24.0 (2025-01-27)
+* Fix add default authority as service name for reflection call
+* Added arm64 builds to release
+
 # 0.23.0 (2024-06-13)
 * Introduce new options --force-jaeger-sample to ensure yab requests are traced.
 

protobuf/source_reflection.go

@@ -43,12 +43,15 @@ func NewDescriptorProviderReflection(args ReflectionArgs) (DescriptorProvider, e
 	}
 	r.InitialState(resolver.State{Addresses: peers})
 
-	conn, err := grpc.DialContext(context.Background(),
+	ctx, cancel := context.WithTimeout(context.Background(), args.Timeout)
+	conn, err := grpc.DialContext(
+		ctx,
 		r.Scheme()+":///", // minimal target to dial registered host:port pairs
-		grpc.WithTimeout(args.Timeout),
+		grpc.WithAuthority(args.Service),
 		grpc.WithBlock(),
 		grpc.WithInsecure())
 	if err != nil {
+		cancel()
 		return nil, fmt.Errorf("could not reach reflection server: %s", err)
 	}
 	pbClient := rpb.NewServerReflectionClient(conn)
@@ -65,7 +68,6 @@ func NewDescriptorProviderReflection(args ReflectionArgs) (DescriptorProvider, e
 		routingHeaders.Append(ygrpc.RoutingKeyHeader, args.RoutingKey)
 	}
 
-	ctx, cancel := context.WithTimeout(context.Background(), args.Timeout)
 	metadataContext := metadata.NewOutgoingContext(ctx, routingHeaders)
 	return &grpcreflectSource{
 		client:     grpcreflect.NewClient(metadataContext, pbClient),

scripts/cross_build.sh

@@ -7,7 +7,7 @@ if [ -z "$VERSION" ]; then
 fi
 
 OSs=(linux darwin)
-ARCHs=(amd64)
+ARCHs=(amd64 arm64)
 
 for OS in "${OSs[@]}"; do
   for ARCH in "${ARCHs[@]}"; do

version.go

@@ -22,4 +22,4 @@ package main
 
 // versionString is the sem-ver version string for yab.
 // It will be bumped explicitly on releases.
-var versionString = "0.23.0"
+var versionString = "0.24.0"