Skip to content

Commit e048d0a

Browse files
authored
Merge pull request #287 from xyz-tools/fix/legacy-batched-mesh
Support webgl 1
2 parents aeb09a5 + 254c7aa commit e048d0a

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/webgl-preview.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -941,7 +941,9 @@ export class WebGLPreview {
941941

942942
geometries.forEach((geometry) => {
943943
const geometryId = batchedMesh.addGeometry(geometry);
944-
batchedMesh.addInstance(geometryId);
944+
// NOTE: for older versions of three.js, addInstance is not available
945+
// This allow webgl1 browsers to use the batched mesh
946+
batchedMesh.addInstance?.(geometryId);
945947
});
946948

947949
return batchedMesh;

0 commit comments

Comments
 (0)