Roll back to Roslyn 4.0.1, to match up against Visual Studio 2022 RTM

Author: bradwilson

src/Directory.Build.props

@@ -23,8 +23,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.6.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis" Version="4.0.1" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
     <PackageReference Include="Nerdbank.GitVersioning" Version="3.6.133">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

src/xunit.analyzers.fixes/xunit.analyzers.fixes.csproj

@@ -5,10 +5,6 @@
     <TargetFramework>netstandard2.0</TargetFramework>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.6.0" />
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\xunit.analyzers\xunit.analyzers.csproj" />
   </ItemGroup>

src/xunit.analyzers/X1000/TestMethodCannotHaveOverloads.cs

@@ -25,13 +25,15 @@ public override void AnalyzeCompilation(
 			if (typeSymbol.TypeKind != TypeKind.Class)
 				return;
 
+#pragma warning disable RS1024 // Compare symbols correctly
 			var methodsByName =
 				typeSymbol
 					.GetInheritedAndOwnMembers()
 					.Where(s => s.Kind == SymbolKind.Method)
 					.Cast<IMethodSymbol>()
 					.Where(m => m.MethodKind == MethodKind.Ordinary)
 					.GroupBy(m => m.Name);
+#pragma warning restore RS1024 // Compare symbols correctly
 
 			foreach (var grouping in methodsByName)
 			{

src/xunit.analyzers/X1000/TestMethodMustNotHaveMultipleFactAttributes.cs

@@ -24,7 +24,9 @@ public override void AnalyzeCompilation(
 			if (context.Symbol is not IMethodSymbol symbol)
 				return;
 
+#pragma warning disable RS1024 // Compare symbols correctly
 			var attributeTypes = new HashSet<INamedTypeSymbol>(SymbolEqualityComparer.Default);
+#pragma warning restore RS1024 // Compare symbols correctly
 
 			var count = 0;
 
@@ -39,13 +41,15 @@ public override void AnalyzeCompilation(
 			}
 
 			if (count > 1)
+#pragma warning disable RS1024 // Compare symbols correctly
 				context.ReportDiagnostic(
 					Diagnostic.Create(
 						Descriptors.X1002_TestMethodMustNotHaveMultipleFactAttributes,
 						symbol.Locations.First(),
 						properties: attributeTypes.ToImmutableDictionary(t => t.ToDisplayString(), t => (string?)string.Empty)
 					)
 				);
+#pragma warning restore RS1024 // Compare symbols correctly
 		}, SymbolKind.Method);
 	}
 }

src/xunit.analyzers/X1000/TheoryMethodShouldUseAllParameters.cs

@@ -55,7 +55,9 @@ static void AnalyzeTheoryParameters(
 		if (!flowAnalysis.Succeeded)
 			return;
 
+#pragma warning disable RS1024 // Compare symbols correctly
 		var usedParameters = new HashSet<ISymbol>(flowAnalysis.ReadInside.Concat(flowAnalysis.Captured).Distinct(SymbolEqualityComparer.Default), SymbolEqualityComparer.Default);
+#pragma warning restore RS1024 // Compare symbols correctly
 
 		for (var i = 0; i < methodSymbol.Parameters.Length; i++)
 		{