fix: refactor CoordinateDependencies, FetchReasons (#1293)

Move them into the "FetchInfo" struct. That struct is ideal for storing
derived data for a Fetch and passing to the later stages of the engine.

Add the BuildFetchReasons option to the planner, that allows other parts
to enable building the FetchReason list.

Author: ysmolski

execution/Makefile

@@ -13,12 +13,13 @@ test-quick:
 update-fixtures:
 	GOLDIE_UPDATE=1 go test -count=1 ./engine/...
 
+# golangci-lint will find the config file in the root dir of the repo.
 .PHONY: format
 format:
-	golangci-lint fmt --config ../.golangci.yml
+	golangci-lint fmt 
 
 lint:
-	golangci-lint run --config ../.golangci.yml .
+	golangci-lint run 
 
 .PHONY: prepare-merge
 prepare-merge: format test

execution/engine/execution_engine_test.go

@@ -231,6 +231,12 @@ func withValueCompletion() executionTestOptions {
 	}
 }
 
+func withFetchReasons() executionTestOptions {
+	return func(options *_executionTestOptions) {
+		options.propagateFetchReasons = true
+	}
+}
+
 func TestExecutionEngine_Execute(t *testing.T) {
 	run := func(testCase ExecutionEngineTestCase, withError bool, expectedErrorMessage string, options ...executionTestOptions) func(t *testing.T) {
 		t.Helper()
@@ -262,6 +268,7 @@ func TestExecutionEngine_Execute(t *testing.T) {
 			for _, option := range options {
 				option(&opts)
 			}
+			engineConf.plannerConfig.BuildFetchReasons = opts.propagateFetchReasons
 			engine, err := NewExecutionEngine(ctx, abstractlogger.Noop{}, engineConf, resolve.ResolverOptions{
 				MaxConcurrency:    1024,
 				ResolvableOptions: opts.resolvableOptions,
@@ -827,7 +834,7 @@ func TestExecutionEngine_Execute(t *testing.T) {
 		},
 	))
 
-	t.Run("execute simple hero operation with propagating to subgraphs reason for fields being requested", runWithoutError(
+	t.Run("execute simple hero operation with propagating to subgraphs fetch reasons", runWithoutError(
 		ExecutionEngineTestCase{
 			schema:    graphql.StarwarsSchema(t),
 			operation: graphql.LoadStarWarsQuery(starwars.FileSimpleHeroQuery, nil),
@@ -875,9 +882,7 @@ func TestExecutionEngine_Execute(t *testing.T) {
 			fields:           []plan.FieldConfiguration{},
 			expectedResponse: `{"data":{"hero":{"name":"Luke Skywalker"}}}`,
 		},
-		func(eto *_executionTestOptions) {
-			eto.propagateFetchReasons = true
-		},
+		withFetchReasons(),
 	))
 
 	t.Run("execute simple hero operation with graphql data source and empty errors list", runWithoutError(
@@ -4539,9 +4544,7 @@ func TestExecutionEngine_Execute(t *testing.T) {
 				dataSources:      makeDataSource(t, true),
 				expectedResponse: `{"data":{"accounts":[{"some":{"title":"User1"}},{"some":{"__typename":"User","id":"2"}},{"some":{"title":"User3"}}]}}`,
 			},
-			func(eto *_executionTestOptions) {
-				eto.propagateFetchReasons = true
-			},
+			withFetchReasons(),
 		))
 	})
 }

go.work

@@ -1,6 +1,6 @@
 go 1.25
 
-toolchain go1.25
+toolchain go1.25.1
 
 use (
 	// v1

v2/Makefile

@@ -13,13 +13,14 @@ test-quick:
 update-fixtures:
 	GOLDIE_UPDATE=1 go test -count=1 ./pkg/...
 
+# golangci-lint will find the config file in the root dir of the repo.
 .PHONY: format
 format:
-	golangci-lint fmt --config ../.golangci.yml
+	golangci-lint fmt 
 
 .PHONY: lint
 lint:
-	golangci-lint run --config ../.golangci.yml .
+	golangci-lint run 
 	cd ../execution && make lint
 
 .PHONY: prepare-merge