Merge branch 'main' into feat/review-emit-workflow-v2

Author: qwen-code-dev-bot

.github/scripts/ci-runner-routing.test.mjs

@@ -1,4 +1,5 @@
-// Runner-routing regression guards for ci.yml and serve-ab.yml.
+// Runner-routing regression guards for ci.yml, serve-ab.yml, and the
+// qwen-autofix.yml scan lane.
 //
 // classify_pr carries the routing logic TWICE — the `runs-on` expression
 // (which selects the classify job's own runner) and the `pick_runner` shell
@@ -68,6 +69,13 @@ function evalRunsOn(expression, { ecsDisabled, eventName, sameRepo, assoc }) {
       /github\.event_name == 'merge_group'/,
       String(eventName === 'merge_group'),
     ],
+    // Longest term first as a convention; both patterns are quote-anchored
+    // (the closing quote is part of each regex), so neither can match
+    // inside the other and the substitution order is behaviorally inert.
+    [
+      /github\.event_name != 'pull_request_review'/,
+      String(eventName !== 'pull_request_review'),
+    ],
     [
       /github\.event_name != 'pull_request'/,
       String(eventName !== 'pull_request'),
@@ -80,6 +88,7 @@ function evalRunsOn(expression, { ecsDisabled, eventName, sameRepo, assoc }) {
       /contains\(fromJSON\('\["OWNER","MEMBER","COLLABORATOR"\]'\), github\.event\.pull_request\.author_association\)/,
       String(TRUSTED.includes(assoc)),
     ],
+    [/github\.repository == 'QwenLM\/qwen-code'/, 'true'],
   ];
   let expr = expression.replace(/^\$\{\{\s*/, '').replace(/\s*\}\}$/, '');
   for (const [term, value] of substitutions) {
@@ -421,3 +430,92 @@ describe('serve-ab.yml runner routing', () => {
     );
   });
 });
+
+describe('qwen-autofix.yml scan-lane runner routing', () => {
+  // route and review-scan gate the WHOLE fan-out: while they sit queued no
+  // review-address leg starts. A hosted-runner backlog queued them past the
+  // cron period, and the cron supersede rule then starved every scan round
+  // (2026-08-25) — so pin the lane on the persistent pool, with the
+  // fork-trust clause and the kill-switch intact.
+  const autofixDoc = parse(
+    readFileSync(join(workflowsDir, 'qwen-autofix.yml'), 'utf8'),
+  );
+  // evalRunsOn unwraps the winning fromJSON label to the array it names, so
+  // compare against arrays, not the ECS/HOSTED string constants above.
+  const ECS_LABELS = ['self-hosted', 'linux', 'x64', 'ecs-qwen'];
+  const HOSTED_LABELS = ['ubuntu-latest'];
+
+  for (const jobName of ['route', 'review-scan']) {
+    const runsOn = String(autofixDoc.jobs[jobName]['runs-on']);
+
+    it(`${jobName} reaches the persistent pool on schedule, dispatch, issue_comment, and issues`, () => {
+      // issue_comment is route's /takeover and /retry lane, issues its
+      // label/assign trigger lane for issue-autofix — pin both beside the
+      // cron and dispatch triggers so a later event-allowlist narrowing of
+      // the pool clause cannot silently demote either back to hosted.
+      for (const eventName of [
+        'schedule',
+        'workflow_dispatch',
+        'issue_comment',
+        'issues',
+      ]) {
+        assert.deepEqual(
+          evalRunsOn(runsOn, {
+            ecsDisabled: false,
+            eventName,
+            sameRepo: false,
+            assoc: '',
+          }),
+          ECS_LABELS,
+          `${jobName} must scan from the pool on ${eventName}`,
+        );
+      }
+    });
+
+    it(`${jobName} keeps untrusted fork PR lanes hosted`, () => {
+      for (const eventName of ['pull_request', 'pull_request_review']) {
+        assert.deepEqual(
+          evalRunsOn(runsOn, {
+            ecsDisabled: false,
+            eventName,
+            sameRepo: false,
+            assoc: 'NONE',
+          }),
+          HOSTED_LABELS,
+          `${jobName} fork lane (${eventName}) must stay hosted`,
+        );
+        assert.deepEqual(
+          evalRunsOn(runsOn, {
+            ecsDisabled: false,
+            eventName,
+            sameRepo: true,
+            assoc: 'NONE',
+          }),
+          ECS_LABELS,
+          `${jobName} same-repo lane (${eventName}) must reach the pool`,
+        );
+      }
+    });
+
+    it(`${jobName} obeys the kill-switch on every event`, () => {
+      for (const eventName of [
+        'schedule',
+        'workflow_dispatch',
+        'issue_comment',
+        'pull_request',
+        'pull_request_review',
+      ]) {
+        assert.deepEqual(
+          evalRunsOn(runsOn, {
+            ecsDisabled: true,
+            eventName,
+            sameRepo: true,
+            assoc: 'OWNER',
+          }),
+          HOSTED_LABELS,
+          `kill-switch must win on ${eventName}`,
+        );
+      }
+    });
+  }
+});

.github/workflows/.size-baseline

@@ -34,7 +34,7 @@
 6495 pr-self-report-label.yml
 9646 qwen-autofix-fork-bridge.yml
 5942 qwen-autofix-fork-signal.yml
-397656 qwen-autofix.yml
+404284 qwen-autofix.yml
 7061 qwen-ci-flaky-rerun.yml
 158010 qwen-code-pr-review.yml
 79041 qwen-fleet-shepherd.yml

.github/workflows/cd-cua-driver.yml

@@ -80,6 +80,12 @@ jobs:
             exit 1
           fi
 
+          DRIVER_VERSION=$(tr -d '[:space:]' < packages/cua-driver/rust/VERSION)
+          if [[ "$DRIVER_VERSION" != "$VERSION" ]]; then
+            echo "::error::Release version $VERSION does not match driver version $DRIVER_VERSION"
+            exit 1
+          fi
+
           SDK_NAME=$(node -p "require('./packages/cua-driver/typescript/package.json').name")
           SDK_VERSION=$(node -p "require('./packages/cua-driver/typescript/package.json').version")
           if [[ "$SDK_NAME" != "@qwen-code/cua-sdk" ]]; then
@@ -803,14 +809,6 @@ jobs:
         with:
           name: 'cua-sdk-npm-${{ needs.validate-version.outputs.version }}'
           path: '${{ runner.temp }}/cua-sdk-package'
-      - name: 'Require npm publishing token'
-        env:
-          NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
-        run: |
-          if [[ -z "$NODE_AUTH_TOKEN" ]]; then
-            echo '::error::production-release NPM_TOKEN is required for the first @qwen-code/cua-sdk publication'
-            exit 1
-          fi
       - name: 'Clean-install against the published GitHub Release'
         env:
           QWEN_CUA_SDK_CACHE_DIR: '${{ runner.temp }}/public-release-cache'
@@ -864,7 +862,6 @@ jobs:
           '
       - name: 'Publish immutable SDK tarball'
         env:
-          NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
           VERSION: '${{ needs.validate-version.outputs.version }}'
         run: |
           set -euo pipefail
@@ -934,17 +931,8 @@ jobs:
           name: 'node-repl-mcp-npm-${{
             needs.validate-version.outputs.node_repl_version }}'
           path: '${{ runner.temp }}/node-repl-package'
-      - name: 'Require npm publishing token'
-        env:
-          NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
-        run: |
-          if [[ -z "$NODE_AUTH_TOKEN" ]]; then
-            echo '::error::production-release NPM_TOKEN is required for the first @qwen-code/node-repl-mcp publication'
-            exit 1
-          fi
       - name: 'Publish immutable Node REPL tarball'
         env:
-          NODE_AUTH_TOKEN: '${{ secrets.NPM_TOKEN }}'
           VERSION: '${{ needs.validate-version.outputs.node_repl_version }}'
         run: |
           set -euo pipefail

.github/workflows/ci.yml

@@ -1029,6 +1029,18 @@ jobs:
         if: "${{ needs.classify_pr.outputs.skip_ci != 'true' && runner.environment == 'self-hosted' }}"
         uses: './.github/actions/configure-windows-runner'
 
+      # Hosted runners expose TEMP through an 8.3 short alias. Self-hosted
+      # runners keep their configured, alias-free RUNNER_TEMP path.
+      - name: 'Point temp at a short-alias-free directory'
+        if: "${{ needs.classify_pr.outputs.skip_ci != 'true' && runner.environment != 'self-hosted' }}"
+        shell: 'powershell'
+        run: |-
+          $temp = Join-Path $env:RUNNER_WORKSPACE 'qwen-code-temp'
+          New-Item -ItemType Directory -Force -Path $temp | Out-Null
+          "TEMP=$temp" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+          "TMP=$temp" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+          Write-Host "TEMP set to $temp"
+
       # Same stale-checkout guard as the Ubuntu gate: this job now runs on ECS,
       # so fail loud if the checkout lacks the merge-queue head rather than
       # silently testing the wrong tree into a merge.
@@ -1059,6 +1071,19 @@ jobs:
         if: "${{ needs.classify_pr.outputs.skip_ci != 'true' && runner.environment == 'self-hosted' }}"
         uses: './.github/actions/self-hosted-node'
 
+      # Compare case-insensitively: Windows paths are case-insensitive and
+      # realpathSync returns the on-disk casing, so a drive-letter or
+      # directory-case difference is the SAME directory under one spelling,
+      # not the 8.3 alias this guards. A strict !== there would fail the
+      # self-hosted lane too — it runs this step against the runner's
+      # pre-existing RUNNER_TEMP — for a reason unrelated to the alias. The
+      # alias case (RUNNER~1 -> runneradmin) differs by more than casing and
+      # still fails; a casing-only difference warns so it stays visible.
+      - name: 'Verify temp paths carry no short alias'
+        if: "${{ needs.classify_pr.outputs.skip_ci != 'true' }}"
+        run: |-
+          node -e "const fs = require('node:fs'); for (const key of ['TEMP', 'TMP']) { const value = process.env[key]; if (!value) { console.error(key + ' is not set'); process.exitCode = 1; continue; } const real = fs.realpathSync(value); if (real === value) continue; if (real.toLowerCase() === value.toLowerCase()) { console.log('::warning::' + key + ' differs from its real path only by casing: ' + value + ' -> ' + real); continue; } console.error(key + ' carries a short alias: ' + value + ' -> ' + real); process.exitCode = 1; }"
+
       - name: 'Configure persistent npm cache (self-hosted)'
         if: "${{ needs.classify_pr.outputs.skip_ci != 'true' && runner.environment == 'self-hosted' }}"
         run: |-

.github/workflows/qwen-autofix.md

@@ -249,6 +249,7 @@ task-oriented guides — what a maintainer types and what happens next — see:
 - [145. review-address · Report dry-run / failure — CUMULATIVE timeout breaker — the sibling of the consecutive one above, for the…](#af-145)
 - [146. review-address · Report dry-run / failure — The agent committed (verify recorded committed=true before any gate could fail),…](#af-146)
 - [147. review-address · Report dry-run / failure — Same byte-budget hygiene as the English excerpt above. 3000 bytes ≈ 1000 CJK…](#af-147)
+- [148. route — Persistent pool, not hosted: a hosted backlog queued route past the cron period, and af-005's…](#af-148)
 
 ---
 
@@ -3727,3 +3728,43 @@ forbids HTML in failure.zh.md), but must not be able to open
 or close a <details>/<summary> that swallows the closing tag
 the workflow emits below.
 ```
+
+<a id="af-148"></a>
+
+### 148. route — Persistent pool, not hosted: a hosted backlog queued route past the cron period, and af-005's supersede then starved every scan round.
+
+In `route` and `review-scan`.
+
+```text
+route and review-scan run on the persistent pool, not the
+hosted one. They are short trusted base-repo jobs, but they
+gate the WHOLE fan-out: while they sit queued, no
+review-address leg starts. On 2026-08-25 a hosted-runner
+backlog queued route for over 20 minutes — longer than the
+cron period — and af-005's newer-tick-supersedes-older rule
+then cancelled every still-queued round: nine consecutive
+schedule runs died without scanning while the ecs-qwen pool
+stood mostly idle. The supersede rule stays — it is right
+once route gets a runner in seconds; the fix is taking the
+hosted queue out of the critical path. review-scan moves
+with it because it shares the gate, and its own hosted waits
+delayed every fan-out by the same backlog. Both keep the
+fork-trust clause of the sibling lanes: pull_request and
+pull_request_review resolve this file from the PR's own
+merge commit, so only same-repo heads and write-access
+authors may reach the persistent pool; everything else stays
+hosted, and the kill-switch wins everywhere. Neither job
+checks code out — route only decides phases, and review-scan
+only calls the API — so the shared workspace needs no
+restore or wipe step here. The pool still leaves two marks
+on the lane, both closed in the same change. One: gh reads
+its config from the shared, attacker-writable $HOME, so both
+steps carry the heavy jobs' gh hardening preamble — a planted
+~/.config/gh/config.yml could reroute their gh calls into a
+local socket, taking CI_DEV_BOT_PAT with the scan and forged
+collaborator-permission answers with route. Two: review-scan
+fills a per-run WORKDIR with API dumps that no VM teardown
+removes on the pool, so it gets a fixed autofix* per-run path
+(the age sweep can reclaim it after a hard kill), an EXIT
+trap, and an always() cleanup step mirroring issue-autofix.
+```