Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

[Bugfix] Include Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp - #3783

Merged
michael-hawker merged 2 commits into
CommunityToolkit:masterfrom
Rosuavio:fix-xmalisland-test
Mar 1, 2021
Merged

[Bugfix] Include Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp#3783
michael-hawker merged 2 commits into
CommunityToolkit:masterfrom
Rosuavio:fix-xmalisland-test

Conversation

@Rosuavio

Copy link
Copy Markdown
Contributor

For some reason this fixes the build errors, it shouldint as its already a transitive dep.

Fixes #3781

Fixes build issue with UnitTest.XamlIslands.UWPApp

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost

ghost commented Feb 24, 2021

Copy link
Copy Markdown

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost
ghost requested review from Kyaa-dost, azchohfi and michael-hawker February 24, 2021 20:09
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 24, 2021
@Rosuavio Rosuavio added XamlIslands 🏝️ for-review 📖 To evaluate and validate the Issues or PR reviewers wanted ✋ and removed bug 🐛 An unexpected issue that highlights incorrect behavior labels Feb 24, 2021
@Rosuavio Rosuavio changed the title Includ Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp Include Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp Feb 24, 2021
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 24, 2021
For some reason this fixes the build errors, it shouldint as its already a transitive dep.
@Rosuavio Rosuavio changed the title Include Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp [Bugfix] Include Microsoft.XamlIslands in UnitTest.XamlIslands.UWPApp Feb 24, 2021

@michael-hawker michael-hawker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michael-hawker
michael-hawker merged commit 014f940 into CommunityToolkit:master Mar 1, 2021
@michael-hawker michael-hawker added this to the 7.0 milestone Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug 🐛 An unexpected issue that highlights incorrect behavior for-review 📖 To evaluate and validate the Issues or PR XamlIslands 🏝️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XamlIslands test project does not build in visual studio.

2 participants