Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

#3070 Stretch the content of the expander header - #3769

Merged
michael-hawker merged 2 commits into
CommunityToolkit:masterfrom
Rosuavio:expander-stretch-2
Feb 19, 2021
Merged

#3070 Stretch the content of the expander header#3769
michael-hawker merged 2 commits into
CommunityToolkit:masterfrom
Rosuavio:expander-stretch-2

Conversation

@Rosuavio

Copy link
Copy Markdown
Contributor

Fixes #3070

PR Type

What kind of change does this PR introduce?

  • Style Change

What is the current behavior?

The Expander Header is left aligned

What is the new behavior?

The expander header will stretch to fit it's space. BREAKING CHANGE

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

This is a breaking *style change. Content that was left aligned will now stretch. This could change how an application looks

Other information

Cherry picked from #3096

@ghost

ghost commented Feb 19, 2021

Copy link
Copy Markdown

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost
ghost requested review from Kyaa-dost, azchohfi and michael-hawker February 19, 2021 16:54
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 19, 2021
@Rosuavio Rosuavio added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 19, 2021
@michael-hawker michael-hawker added this to the 7.0 milestone Feb 19, 2021
@ghost

ghost commented Feb 19, 2021

Copy link
Copy Markdown

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 20 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
michael-hawker merged commit 4b92896 into CommunityToolkit:master Feb 19, 2021
@Rosuavio
Rosuavio deleted the expander-stretch-2 branch February 19, 2021 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expander Header is hard to Stretch

3 participants