Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Update PULL_REQUEST_TEMPLATE.md - #3592

Merged
michael-hawker merged 4 commits into
CommunityToolkit:masterfrom
Kyaa-dost:Kyaa/PR-Instructions
Dec 2, 2020
Merged

Update PULL_REQUEST_TEMPLATE.md#3592
michael-hawker merged 4 commits into
CommunityToolkit:masterfrom
Kyaa-dost:Kyaa/PR-Instructions

Conversation

@Kyaa-dost

Copy link
Copy Markdown
Contributor

Fixes

PR Type

What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?

Missing instructions regarding not to uncheck "Allow edits by maintainers"

What is the new behavior?

Provides instructions on not to uncheck "Allow edits by maintainers" option in the PR template of forked branch.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost

ghost commented Dec 1, 2020

Copy link
Copy Markdown

Thanks Kyaa-dost for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost
ghost requested review from azchohfi and michael-hawker December 1, 2020 20:57
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
@ghost

ghost commented Dec 1, 2020

Copy link
Copy Markdown

Hello @Kyaa-dost!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 44 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
michael-hawker merged commit 54c7c8c into CommunityToolkit:master Dec 2, 2020
@Kyaa-dost
Kyaa-dost deleted the Kyaa/PR-Instructions branch December 2, 2020 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants