Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

Create separate instances of GazePointer per (UI) thread, - #3590

Merged
3 commits merged into
masterfrom
petea/issues/3589
Dec 9, 2020
Merged

Create separate instances of GazePointer per (UI) thread,#3590
3 commits merged into
masterfrom
petea/issues/3589

Conversation

@peteams

@peteams peteams commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

Fixes

Fixes #3589

PR Type

What kind of change does this PR introduce?

<- Bugfix

What is the current behavior?

One GazePointer object per application.

What is the new behavior?

One GazePointer object per (UI) thread.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost

ghost commented Nov 30, 2020

Copy link
Copy Markdown

Thanks peteams for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost
ghost requested review from Kyaa-dost, azchohfi and michael-hawker November 30, 2020 21:25
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Nov 30, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Nov 30, 2020
@ghost ghost added the in progress 🚧 label Nov 30, 2020
@ghost

ghost commented Dec 8, 2020

Copy link
Copy Markdown

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker

Copy link
Copy Markdown
Member

Thanks @peteams works great!

@Kyaa-dost Kyaa-dost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@Kyaa-dost

Copy link
Copy Markdown
Contributor

@msftbot merge this PR

@ghost

ghost commented Dec 9, 2020

Copy link
Copy Markdown

Hello @Kyaa-dost!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@Kyaa-dost

Copy link
Copy Markdown
Contributor

@msftbot Nevermind

@ghost

ghost commented Dec 9, 2020

Copy link
Copy Markdown

Hello @Kyaa-dost!

Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request.

@ghost
ghost merged commit 1ebc426 into master Dec 9, 2020
@ghost
ghost deleted the petea/issues/3589 branch December 9, 2020 01:36
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior in progress 🚧

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gaze only works for initial UI thread of an application

4 participants