Skip to content

Commit ba3012e

Browse files
xhochywesm
authored andcommitted
PARQUET-634: Consistent private linking of dependencies
Link all (static) third-party dependencies privately to not expose their API. Also combine all static libs containing public interfaces into one. To correctly link against parquet_static from another lib, you still need all thirdparty static libs but at least the main parquet static library is only a single one. Will address the scenario "single static lib with all dependencies included" later once we have visibility macros. Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#120 from xhochy/parquet-634 and squashes the following commits: 7059b74 [Uwe L. Korn] PARQUET-634: Consistent private linking of dependencies Change-Id: I7d32dc4b129e15109fe5e7003b7401c485c1b8a8
1 parent b1a816d commit ba3012e

2 files changed

Lines changed: 0 additions & 22 deletions

File tree

cpp/src/parquet/compression/CMakeLists.txt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,6 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
add_library(parquet_compression STATIC
19-
codec.cc
20-
snappy-codec.cc
21-
gzip-codec.cc
22-
)
23-
target_link_libraries(parquet_compression
24-
snappystatic
25-
zlibstatic)
26-
27-
set_target_properties(parquet_compression
28-
PROPERTIES
29-
LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}")
30-
3118
# Headers: compression
3219
install(FILES
3320
codec.h

cpp/src/parquet/util/CMakeLists.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,6 @@ install(FILES
3636
sse-util.h
3737
DESTINATION include/parquet/util)
3838

39-
add_library(parquet_util STATIC
40-
buffer.cc
41-
cpu-info.cc
42-
input.cc
43-
mem-allocator.cc
44-
mem-pool.cc
45-
output.cc
46-
)
47-
4839
if(PARQUET_BUILD_TESTS)
4940
add_library(parquet_test_main
5041
test_main.cc)

0 commit comments

Comments
 (0)