fix: add safe traverse to loaderoptionsplugin - #77
Merged
Conversation
okonet
suggested changes
Feb 28, 2017
okonet
left a comment
okonet
left a comment
Contributor
There was a problem hiding this comment.
Can we add tests specific to this case please?
Otherwise LGTM! 
Author
|
Good idea. Added one. The test case throws undefined error without the fix. |
evenstensberg
pushed a commit
that referenced
this pull request
Mar 4, 2017
* fix: add safe traverse to loaderoptionsplugin * test: write a failing test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Solves #76, #69
Other information