refactor: apply `webpack-defaults` by bebraw · Pull Request #35 · webpack-contrib/uglifyjs-webpack-plugin

bebraw · 2017-05-27T06:15:58Z

Closes #24.

codecov · 2017-05-27T06:19:51Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0f58cd0). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             master   #35   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     2           
  Lines             ?   132           
  Branches          ?    46           
======================================
  Hits              ?     0           
  Misses            ?    91           
  Partials          ?    41

Impacted Files	Coverage Δ
src/index.js	`0% <0%> (ø)`
src/cjs.js	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f58cd0...0659f13. Read the comment docs.

michael-ciniawsky

Latest webpack-defaults is the only obvious task left :) (yarn -> npm@5), if we land it sooner then later with the latest uglify@2 it can substitute lib/optimize/UglifyJSPlugin in webpack 3 as the (hopefully) last uglify@2 release

bebraw · 2017-06-07T07:38:15Z

I updated it to webpack-defaults 1.1. I don't mind bumping later again.

The only thing I noticed is that it overrode ESLint completely. I had to disable a couple of rules to accommodate to the project so those were lost. Is this by design?

Jessidhia · 2017-06-07T07:41:30Z

Yes, webpack-defaults always overrides the eslint settings; presumably to install new rules if any are added to defaults.

Not sure if it's intentional that it doesn't support customizations at all.

bebraw · 2017-06-07T07:58:08Z

@Kovensky Ok, track webpack-contrib/webpack-defaults#59 .

joshwiens

Delete the yarn.lock & replace with package-lock.json

joshwiens · 2017-06-11T19:23:00Z

+matrix:
+  fast_finish: true
+install:
+  - 'ps: Install-Product node $env:nodejs_version x64'


You have to strip the ' off of anything that has ps: || cmd:. Already has an open issue in defaults.

joshwiens · 2017-06-11T19:24:06Z

@@ -1,10 +1,34 @@
+sudo: false


Pickup webpack-defaults@1.4.0 for all the psudo canary Travis changes.

joshwiens · 2017-06-11T19:25:09Z

    "eslint-plugin-node": "^4.0.1",
    "eslint-plugin-react": "^6.9.0",
    "git-prepush-hook": "^1.0.1",
    "jest": "^18.1.0",


Change to "jest": "^20.0.4",,

joshwiens · 2017-06-11T19:25:27Z

@@ -56,23 +69,40 @@
    "babel-jest": "^18.0.0",


Change to "babel-jest": "^20.0.3",

joshwiens · 2017-06-11T19:26:44Z

    "babel-preset-es2015": "^6.18.0",
+    "cross-env": "^5.0.0",
+    "del-cli": "^1.0.0",
    "eslint": "^3.13.1",


Strip the eslint deps in favor of ..

"eslint": "^3.19.0", "eslint-config-webpack": "^1.2.3", "eslint-plugin-import": "^2.3.0",

joshwiens · 2017-06-11T19:27:09Z

    "eslint-plugin-jsx-a11y": "^3.0.2",
    "eslint-plugin-node": "^4.0.1",
    "eslint-plugin-react": "^6.9.0",
    "git-prepush-hook": "^1.0.1",


Shouldn't need this anymore?

joshwiens · 2017-06-11T19:28:11Z

    "babel-jest": "^18.0.0",
    "babel-plugin-syntax-object-rest-spread": "^6.13.0",
    "babel-plugin-transform-object-rest-spread": "^6.20.2",
+    "babel-polyfill": "^6.23.0",


Strip all the Babel in favor of ...

"babel-cli": "^6.24.1", "babel-jest": "^20.0.3", "babel-plugin-transform-object-rest-spread": "^6.23.0", "babel-polyfill": "^6.23.0", "babel-preset-env": "^1.5.2",

joshwiens · 2017-06-11T19:30:49Z

    "sync-exec": "^0.6.2",
    "uglify-js": "^2.8.18",
-    "webpack": "^2.2.0"
+    "webpack": "^2.2.0",


Pull the hard devDependency on webpack

joshwiens · 2017-06-11T19:45:04Z

@Kovensky - webpack-defaults always overrides the eslint settings is very intentional.

The entire point of defaults was to standardize all of the loaders & plugins in contrib to simplify contributions & maintenance, this includes amongst other things, code style. We have a single way of doing things because in the end, it's always going to be a small group of people handling a vast majority of the project maintenance.

Rules can be overridden in the .eslintrc if it's necessary or a pull request can be opened in eslint-config-webpack for rules that should be changed across the board.

There is discussion about using Prettier in the future but as it stands right now, there is far more value in getting the standards work done than tinkering around with stylistic debates. We can take another stylistic pass, probably with prettier in webpac-defaults 2.x along with the schema-utils updates but until https://github.com/orgs/webpack-contrib/projects/5 board is cleared, we are going with good enough

michael-ciniawsky · 2017-06-28T00:15:56Z

Updated to webpack-defaults v1.4.0 can I merge it so we can start backporting the test and update to uglify >= v3.0.0 ?

michael-ciniawsky · 2017-06-28T00:20:48Z

Why is the CI not working? 😕 😭

…s` (#45)

TheLarkInn · 2017-06-29T03:14:26Z

Shipit.

* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` * refactor(package): rm `pre-push` hook * chore: rm `yarn.lock` * fix(index): linting

* fix(package): mv uglify2 to `dependencies` && update `peerDependencies` (#45) * refactor: apply to `webpack-defaults` * chore(package): update `webpack-defaults v1.0.1...1.4.0` BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": ">= 3.0.0-rc.0 || ^3.0.0"`. BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`

bebraw mentioned this pull request May 27, 2017

Support UglifyJS 3 #32

Closed

bebraw force-pushed the feature-defaults branch from a22daf7 to bcb1bfd Compare June 6, 2017 07:48

michael-ciniawsky reviewed Jun 6, 2017

View reviewed changes

michael-ciniawsky added priority: 1 (critical) pr_action: Review semver: Major type: Refactor labels Jun 6, 2017

bebraw force-pushed the feature-defaults branch from bcb1bfd to 3420a92 Compare June 7, 2017 07:36

bebraw mentioned this pull request Jun 7, 2017

feat: Allow eslint customization per project? webpack-contrib/webpack-defaults#59

Closed

bebraw force-pushed the feature-defaults branch 2 times, most recently from d295a5e to 23733c2 Compare June 10, 2017 07:42

joshwiens reviewed Jun 11, 2017

View reviewed changes

michael-ciniawsky changed the title ~~chore: Update to webpack-defaults~~ refactor: apply webpack-defaults Jun 22, 2017

michael-ciniawsky added this to the 1.0.0 milestone Jun 22, 2017

michael-ciniawsky requested review from alexander-akait, hulkish, joshwiens and michael-ciniawsky June 28, 2017 00:13

michael-ciniawsky self-assigned this Jun 28, 2017

michael-ciniawsky force-pushed the feature-defaults branch from e77fc28 to e9b2596 Compare June 28, 2017 01:46

michael-ciniawsky closed this Jun 28, 2017

michael-ciniawsky reopened this Jun 28, 2017

fix(package): mv uglify2 to dependencies && update `peerDependencie…

98d2d66

…s` (#45)

bebraw and others added 4 commits June 28, 2017 03:58

refactor: apply to webpack-defaults

be54344

chore(package): update webpack-defaults v1.0.1...1.4.0

48f7d94

refactor(package): rm pre-push hook

74ea5f1

chore: rm yarn.lock

07ca8fe

michael-ciniawsky force-pushed the feature-defaults branch from 9339e12 to 07ca8fe Compare June 28, 2017 02:01

michael-ciniawsky approved these changes Jun 28, 2017

View reviewed changes

fix(index): linting

0659f13

TheLarkInn merged commit 3bd2f1f into master Jun 29, 2017

michael-ciniawsky removed this from the 2.0.0 milestone Oct 29, 2017

Uh oh!

Uh oh!

Conversation

bebraw commented May 27, 2017

Uh oh!

codecov Bot commented May 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

bebraw commented Jun 7, 2017

Uh oh!

Jessidhia commented Jun 7, 2017

Uh oh!

bebraw commented Jun 7, 2017

Uh oh!

joshwiens left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshwiens commented Jun 11, 2017

Uh oh!

michael-ciniawsky commented Jun 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky commented Jun 28, 2017

Uh oh!

TheLarkInn commented Jun 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented May 27, 2017 •

edited

Loading

michael-ciniawsky commented Jun 28, 2017 •

edited

Loading