fix: validation schema (schema-utils) - #527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 90.38% 90.11% -0.28%
==========================================
Files 6 4 -2
Lines 364 354 -10
Branches 77 76 -1
==========================================
- Hits 329 319 -10
Misses 35 35
Continue to review full report at Codecov.
|
|
@bebraw - Wouldn't it just make more sense to migrate this to schema utils and maintain the |
|
@d3viant0ne Agreed. @evilebottnawi Can you make that change? Better solution over longer term. |
|
@bebraw let's do it |
0ec10e6 to
0de03b4
Compare
|
/cc @d3viant0ne @bebraw |
michael-ciniawsky
changed the title
schema-utils
| var loaderUtils = require("loader-utils"); | ||
| var schemaTester = require('./schema/validator'); | ||
| var validateOptions = require('schema-utils'); | ||
| var loaderSchema = require('./schema/loader-schema'); |
There was a problem hiding this comment.
The two schemas can be removed, just pass the path/to/schema.json to validateOptions
| options = { filename: options }; | ||
| } else { | ||
| schemaTester(pluginSchema, options); | ||
| validateOptions(pluginSchema, options, ' Extract Text Plugin'); |
There was a problem hiding this comment.
./schema/plugin.json && Extract Text Plugin => Extract Text Plugin (no leading space)
Please rename plugin-schema.js => plugin.json
| options = { loader: options }; | ||
| } else { | ||
| schemaTester(loaderSchema, options); | ||
| validateOptions(loaderSchema, options, 'Extract Text Loader'); |
There was a problem hiding this comment.
./schema/loader.json && Extract Text Loader => Extract Text Plugin (Loader)
Please rename loader-schema.js => loader.json
| }, | ||
| function(err) { | ||
| return err.message === 'data[\'style\'] should NOT have additional properties'; | ||
| console.log(err.message) |
There was a problem hiding this comment.
Needed for tests or forgotten to remove ? 😛
0de03b4 to
7ea0b2b
Compare
| options = { filename: options }; | ||
| } else { | ||
| schemaTester(pluginSchema, options); | ||
| validateOptions('schema/plugin.json', options, 'Extract Text Plugin'); |
There was a problem hiding this comment.
Just to double check => ./ <= schema... ? (validateOptions use require() 'internally')
| options = { loader: options }; | ||
| } else { | ||
| schemaTester(loaderSchema, options); | ||
| validateOptions('schema/loader.json', options, 'Extract Text Plugin (Loader)'); |
7ea0b2b to
541ab86
Compare
|
/cc @michael-ciniawsky done |
michael-ciniawsky
changed the title
schema-utilsschema-utils)
4 participants
Fixes #524
We can avoid using
$schemaas we can do inwebpack(https://github.com/webpack/webpack/tree/master/schemas)