Skip to content

Commit d424733

Browse files
tt-a1ichenjiahan
andauthored
fix(lint): enable @typescript-eslint/await-thenable rule (#12644)
* fix(lint): enable await-thenable rule and fix violation - Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void * Update rslint.json --------- Co-authored-by: neverland <jait.chen@foxmail.com>
1 parent 25a4021 commit d424733

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

packages/rspack/src/exports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ export const experiments: Experiments = {
416416
},
417417
async cleanup() {
418418
await JavaScriptTracer.cleanupJavaScriptTrace();
419-
await syncTraceEvent(JavaScriptTracer.events);
419+
syncTraceEvent(JavaScriptTracer.events);
420420
cleanupGlobalTrace();
421421
},
422422
},

rslint.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"@typescript-eslint/use-unknown-in-catch-callback-variable": "off",
2828
"@typescript-eslint/require-await": "off",
2929
"@typescript-eslint/switch-exhaustiveness-check": "off",
30-
"@typescript-eslint/await-thenable": "off",
3130
"@typescript-eslint/return-await": "off",
3231
"@typescript-eslint/non-nullable-type-assertion-style": "off",
3332
"@typescript-eslint/no-misused-spread": "off",

0 commit comments

Comments
 (0)