Skip to content

Commit e18b960

Browse files
Copilotsawka
andcommitted
Fix preview object service path
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
1 parent 185fb4a commit e18b960

3 files changed

Lines changed: 22 additions & 6 deletions

File tree

frontend/app/view/preview/preview-model.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ export class PreviewModel implements ViewModel {
587587
return;
588588
}
589589
const blockOref = WOS.makeORef("block", this.blockId);
590-
await this.env.services.ObjectService.UpdateObjectMeta(blockOref, updateMeta);
590+
await this.env.services.object.UpdateObjectMeta(blockOref, updateMeta);
591591

592592
// Clear the saved file buffers
593593
globalStore.set(this.fileContentSaved, null);
@@ -623,7 +623,7 @@ export class PreviewModel implements ViewModel {
623623
}
624624
updateMeta.edit = false;
625625
const blockOref = WOS.makeORef("block", this.blockId);
626-
await this.env.services.ObjectService.UpdateObjectMeta(blockOref, updateMeta);
626+
await this.env.services.object.UpdateObjectMeta(blockOref, updateMeta);
627627
}
628628

629629
async goHistoryForward() {
@@ -635,13 +635,13 @@ export class PreviewModel implements ViewModel {
635635
}
636636
updateMeta.edit = false;
637637
const blockOref = WOS.makeORef("block", this.blockId);
638-
await this.env.services.ObjectService.UpdateObjectMeta(blockOref, updateMeta);
638+
await this.env.services.object.UpdateObjectMeta(blockOref, updateMeta);
639639
}
640640

641641
async setEditMode(edit: boolean) {
642642
const blockMeta = globalStore.get(this.blockAtom)?.meta;
643643
const blockOref = WOS.makeORef("block", this.blockId);
644-
await this.env.services.ObjectService.UpdateObjectMeta(blockOref, { ...blockMeta, edit });
644+
await this.env.services.object.UpdateObjectMeta(blockOref, { ...blockMeta, edit });
645645
}
646646

647647
async handleFileSave() {
@@ -790,7 +790,7 @@ export class PreviewModel implements ViewModel {
790790
click: () =>
791791
fireAndForget(async () => {
792792
const blockOref = WOS.makeORef("block", this.blockId);
793-
await this.env.services.ObjectService.UpdateObjectMeta(blockOref, {
793+
await this.env.services.object.UpdateObjectMeta(blockOref, {
794794
"editor:wordwrap": !wordWrap,
795795
});
796796
}),

frontend/app/view/preview/previewenv.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export type PreviewEnv = WaveEnvSubset<{
2626
fullConfigAtom: WaveEnv["atoms"]["fullConfigAtom"];
2727
};
2828
services: {
29-
ObjectService: WaveEnv["services"]["ObjectService"];
29+
object: WaveEnv["services"]["object"];
3030
};
3131
wos: WaveEnv["wos"];
3232
getSettingsKeyAtom: SettingsKeyAtomFnType<"preview:showhiddenfiles" | "editor:fontsize" | "preview:defaultsort">;

frontend/preview/previews/suggestion.preview.test.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,20 @@ describe("suggestion preview helpers", () => {
4747
expect(result).toBeNull();
4848
expect(disposeSuggestionsCommand).toHaveBeenCalledOnce();
4949
});
50+
51+
it("uses the lowercase object service key exposed by WaveEnv", async () => {
52+
const updateObjectMeta = vi.fn(async () => null);
53+
const env = makeMockWaveEnv({
54+
services: {
55+
object: {
56+
UpdateObjectMeta: updateObjectMeta,
57+
},
58+
},
59+
});
60+
61+
await env.services.object.UpdateObjectMeta("block:test", { file: "/Users/mike/Documents/meeting-notes.md" });
62+
63+
expect(updateObjectMeta).toHaveBeenCalledOnce();
64+
expect(updateObjectMeta).toHaveBeenCalledWith("block:test", { file: "/Users/mike/Documents/meeting-notes.md" });
65+
});
5066
});

0 commit comments

Comments
 (0)