change tab position from context menu

Author: sawka

frontend/app/tab/tab.tsx

@@ -19,13 +19,15 @@ import { buildTabContextMenu } from "./tabcontextmenu";
 export type TabEnv = WaveEnvSubset<{
     rpc: {
         ActivityCommand: WaveEnv["rpc"]["ActivityCommand"];
+        SetConfigCommand: WaveEnv["rpc"]["SetConfigCommand"];
         SetMetaCommand: WaveEnv["rpc"]["SetMetaCommand"];
         UpdateTabNameCommand: WaveEnv["rpc"]["UpdateTabNameCommand"];
     };
     atoms: {
         fullConfigAtom: WaveEnv["atoms"]["fullConfigAtom"];
     };
     wos: WaveEnv["wos"];
+    getSettingsKeyAtom: WaveEnv["getSettingsKeyAtom"];
     showContextMenu: WaveEnv["showContextMenu"];
 }>;
 

frontend/app/tab/tabcontextmenu.ts

@@ -85,6 +85,22 @@ function buildTabContextMenu(
         }
         menu.push({ label: "Backgrounds", type: "submenu", submenu }, { type: "separator" });
     }
+    const currentTabBar = globalStore.get(env.getSettingsKeyAtom("app:tabbar")) ?? "top";
+    const tabBarSubmenu: ContextMenuItem[] = [
+        {
+            label: "Top",
+            type: "checkbox",
+            checked: currentTabBar === "top",
+            click: () => fireAndForget(() => env.rpc.SetConfigCommand(TabRpcClient, { "app:tabbar": "top" })),
+        },
+        {
+            label: "Left",
+            type: "checkbox",
+            checked: currentTabBar === "left",
+            click: () => fireAndForget(() => env.rpc.SetConfigCommand(TabRpcClient, { "app:tabbar": "left" })),
+        },
+    ];
+    menu.push({ label: "Tab Bar Position", type: "submenu", submenu: tabBarSubmenu }, { type: "separator" });
     menu.push({ label: "Close Tab", click: () => onClose(null) });
     return menu;
 }

frontend/app/tab/vtabbarenv.ts

@@ -13,6 +13,7 @@ export type VTabBarEnv = WaveEnvSubset<{
         UpdateWorkspaceTabIdsCommand: WaveEnv["rpc"]["UpdateWorkspaceTabIdsCommand"];
         UpdateTabNameCommand: WaveEnv["rpc"]["UpdateTabNameCommand"];
         ActivityCommand: WaveEnv["rpc"]["ActivityCommand"];
+        SetConfigCommand: WaveEnv["rpc"]["SetConfigCommand"];
         SetMetaCommand: WaveEnv["rpc"]["SetMetaCommand"];
     };
     atoms: {
@@ -23,7 +24,7 @@ export type VTabBarEnv = WaveEnvSubset<{
     };
     wos: WaveEnv["wos"];
     showContextMenu: WaveEnv["showContextMenu"];
-    getSettingsKeyAtom: SettingsKeyAtomFnType<"tab:confirmclose">;
+    getSettingsKeyAtom: SettingsKeyAtomFnType<"tab:confirmclose" | "app:tabbar">;
     mockSetWaveObj: WaveEnv["mockSetWaveObj"];
     isWindows: WaveEnv["isWindows"];
     isMacOS: WaveEnv["isMacOS"];