Skip to content

Commit 99dec65

Browse files
committed
Merge pull request #4025 from GCorbel/master
Use keyForReliationship for belongsTo and hasMany
2 parents 1332045 + 6951988 commit 99dec65

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

addon/-private/serializers/embedded-records-mixin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export default Ember.Mixin.create({
217217

218218
_serializeEmbeddedBelongsTo(snapshot, json, relationship) {
219219
let embeddedSnapshot = snapshot.belongsTo(relationship.key);
220-
let serializedKey = this.keyForAttribute(relationship.key, 'serialize');
220+
let serializedKey = this.keyForRelationship(relationship.key, 'serialize');
221221
if (!embeddedSnapshot) {
222222
json[serializedKey] = null;
223223
} else {
@@ -332,7 +332,7 @@ export default Ember.Mixin.create({
332332
},
333333

334334
_serializeEmbeddedHasMany(snapshot, json, relationship) {
335-
let serializedKey = this.keyForAttribute(relationship.key, 'serialize');
335+
let serializedKey = this.keyForRelationship(relationship.key, 'serialize');
336336

337337
warn(
338338
`The embedded relationship '${serializedKey}' is undefined for '${snapshot.modelName}' with id '${snapshot.id}'. Please include it in your original payload.`,

tests/integration/serializers/embedded-records-mixin-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ test("serialize with embedded objects and a custom keyForAttribute (hasMany rela
910910
});
911911

912912
env.registry.register('serializer:home-planet', DS.RESTSerializer.extend(DS.EmbeddedRecordsMixin, {
913-
keyForAttribute(key) {
913+
keyForRelationship(key) {
914914
return key + '-custom';
915915
},
916916
attrs: {
@@ -926,7 +926,7 @@ test("serialize with embedded objects and a custom keyForAttribute (hasMany rela
926926
});
927927

928928
assert.deepEqual(json, {
929-
"name-custom": "Villain League",
929+
"name": "Villain League",
930930
"villains-custom": [{
931931
id: get(tom, "id"),
932932
firstName: "Tom",

0 commit comments

Comments
 (0)