Skip to content

Commit 83ed89a

Browse files
committed
ci: make just lint the single source of truth for clippy
The nightly-2026-06-10 bump (#1725) added allows for new clippy lints (unused_async_trait_impl, useless_borrows_in_formatting) to the CI clippy command only, so local just lint failed on the vendored rolldown crates. Move the allow flags into the just lint recipe and have CI run just lint, so there is no second copy to keep in sync.
1 parent 491cd3f commit 83ed89a

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -168,20 +168,13 @@ jobs:
168168
with:
169169
save-cache: ${{ github.ref_name == 'main' }}
170170
cache-key: lint
171-
tools: cargo-shear
171+
tools: just,cargo-shear
172172
components: clippy rust-docs rustfmt
173173

174174
- run: |
175175
cargo shear
176176
cargo fmt --check
177-
# Allow new clippy lints from the toolchain that fire in upstream
178-
# rolldown crates without a `[lints]` table.
179-
cargo clippy --all-targets --all-features -- -D warnings \
180-
-A clippy::byte_char_slices \
181-
-A clippy::manual_assert_eq \
182-
-A clippy::needless_return_with_question_mark \
183-
-A clippy::unused_async_trait_impl \
184-
-A clippy::useless_borrows_in_formatting
177+
just lint
185178
# RUSTDOCFLAGS='-D warnings' cargo doc --no-deps --document-private-items
186179
187180
- uses: crate-ci/typos@37bb98842b0d8c4ffebdb75301a13db0267cef89 # v1.47.2

justfile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,15 @@ test:
7575
test:
7676
$packages = Get-ChildItem -Path crates -Directory | ForEach-Object { '-p'; $_.Name }; $Env:__COMPAT_LAYER='RunAsInvoker'; cargo test @packages -p vite-plus-cli
7777

78+
# Single source of truth for clippy, used by CI too. The `-A` flags allow
79+
# new toolchain lints that fire in upstream rolldown crates without a `[lints]` table.
7880
lint:
79-
cargo clippy --workspace --all-targets --all-features -- --deny warnings
81+
cargo clippy --workspace --all-targets --all-features -- --deny warnings \
82+
-A clippy::byte_char_slices \
83+
-A clippy::manual_assert_eq \
84+
-A clippy::needless_return_with_question_mark \
85+
-A clippy::unused_async_trait_impl \
86+
-A clippy::useless_borrows_in_formatting
8087

8188
[unix]
8289
doc:

0 commit comments

Comments
 (0)