address PR feedback

Author: vmoroz

node.gyp

@@ -113,8 +113,9 @@
       'src/node_debug.cc',
       'src/node_dir.cc',
       'src/node_dotenv.cc',
-      'src/node_env_var.cc',
       'src/node_embedding_api.cc',
+      'src/node_embedding_api.h',
+      'src/node_env_var.cc',
       'src/node_errors.cc',
       'src/node_external_reference.cc',
       'src/node_file.cc',

src/node_embedding_api.cc

@@ -13,16 +13,13 @@
 // C-based API.
 //
 
+#include "node_embedding_api.h"
 #include "node.h"
 
-extern "C" {
-  #ifdef _WIN32
-  __declspec(dllexport) int node_embedding_start(int argc, char** argv) {
-    return node::Start(argc, argv);
-  }
-  #else
-  int node_embedding_start(int argc, char** argv) {
-    return node::Start(argc, argv);
-  }
-  #endif
+EXTERN_C_START
+
+int32_t NAPI_CDECL node_embedding_main(int32_t argc, char* argv[]) {
+  return node::Start(argc, argv);
 }
+
+EXTERN_C_END

src/node_embedding_api.h

@@ -13,11 +13,18 @@
 // C-based API.
 //
 
-#include "node.h"
+#ifndef SRC_NODE_EMBEDDING_API_H_
+#define SRC_NODE_EMBEDDING_API_H_
 
-#ifdef _WIN32
-int __cdecl node_embedding_start(int argc, char** argv);
-#else
-int node_embedding_start(int argc, char** argv);
-#endif
+#include "node_api.h"
 
+#define NODE_EMBEDDING_VERSION 1
+
+EXTERN_C_START
+
+// Runs Node.js main function. It is the same as running Node.js from CLI.
+NAPI_EXTERN int32_t NAPI_CDECL node_embedding_main(int32_t argc, char* argv[]);
+
+EXTERN_C_END
+
+#endif  // SRC_NODE_EMBEDDING_API_H_