fix(define): fix match escaped dots to support $-prefixed define keys (#23249)

Author: contactjawad

packages/vite/src/node/__tests__/plugins/define.spec.ts

@@ -90,6 +90,15 @@ describe('definePlugin (SSR dev)', () => {
     ).toBe(undefined)
   })
 
+  test('replaces define keys containing `$`', async () => {
+    const transform = await createJsDefinePluginTransform({
+      $FOO: JSON.stringify('bar'),
+    })
+    expect(await transform('export const x = $FOO;')).toBe(
+      'export const x = "bar";\n',
+    )
+  })
+
   test('replace import.meta.env when it is a invalid json', async () => {
     const transform = await createJsDefinePluginTransform({
       'import.meta.env.LEGACY': '__VITE_IS_LEGACY__',

packages/vite/src/node/plugins/define.ts

@@ -7,7 +7,7 @@ import { isHTMLRequest } from './html'
 
 const nonJsRe = /\.json(?:$|\?)/
 const isNonJsRequest = (request: string): boolean => nonJsRe.test(request)
-const escapedDotRE = /(?<!\\)\\./g
+const escapedDotRE = /(?<!\\)\\\./g
 
 export function definePlugin(config: ResolvedConfig): Plugin {
   const isBuild = config.command === 'build'