fix(rsc): isolate plugin state per plugin instance#747
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors RSC plugin state management from module-level global variables to an isolated RscPluginManager class instance per plugin instance, enabling proper state isolation between multiple plugin instances.
Key changes:
- Introduces
RscPluginManagerclass to encapsulate all plugin state - Updates all plugin functions to accept and use the manager instance
- Adds test to verify independent plugin state isolation during multiple builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/plugin-rsc/src/plugin.ts | Removes global state variables, adds RscPluginManager class, and refactors all plugin functions to use manager instance |
| packages/plugin-rsc/e2e/starter.test.ts | Adds test case to verify plugin state isolation between multiple builds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently all plugin states are managed in module scope (as a reminiscence of my original prototype). These states should be isolated per plugin instance. This also helps splitting up more plugins from single file
plugin.ts. Also helps fixing an issues like #575.For now, let's do something mechanical by moving the state to
RscPluginManagerand just passing aroundmanager. As a follow up, we could move some helpers to manager class such asassetURLmethod.TODO