test(rsc): split starter tests into multiple files#629
Merged
Conversation
- Extract defineTest utility to starter.ts - Split tests into logical groups: - starter-basic.test.ts: Basic starter tests (dev/build for default and cloudflare) - starter-no-ssr.test.ts: No-SSR specific tests with build verification - starter-env.test.ts: Environment-specific tests (production/development modes) - starter-react-compiler.test.ts: React compiler integration tests - starter-base.test.ts: Base path configuration tests - starter-module-runner.test.ts: Module runner HMR configuration tests - starter-render-built-url.test.ts: renderBuiltUrl configuration tests Benefits: - Tests can now run in parallel for faster CI execution - Better organization by functionality/configuration - Easier maintenance with focused test files - Maintains backward compatibility with original starter.test.ts To run all starter tests: pnpm test-e2e starter-basic starter-no-ssr starter-env starter-react-compiler starter-base starter-module-runner starter-render-built-url
- Remove unused starter.test.ts file - Merge starter-basic.test.ts and starter-env.test.ts into basic.test.ts since they share the same fixture root (examples/starter) - Remove 'starter-' prefix from all test files for cleaner naming: - starter-no-ssr.test.ts → no-ssr.test.ts - starter-react-compiler.test.ts → react-compiler.test.ts - starter-base.test.ts → base.test.ts - starter-module-runner.test.ts → module-runner.test.ts - starter-render-built-url.test.ts → render-built-url.test.ts Now only truly independent test files (different fixture roots) are split, allowing for optimal parallelization while maintaining logical grouping.
hi-ogawa
force-pushed
the
refactor/split-starter-tests
branch
from
ea9fba6 to
b65e9a6
Compare
- Restored the original basic.test.ts for examples/basic (comprehensive test suite) - Created new starter.test.ts for examples/starter tests (lightweight template tests) - Both files now work correctly and independently
hi-ogawa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Cursor
Benefits:
To run all starter tests:
pnpm test-e2e starter-basic starter-no-ssr starter-env starter-react-compiler starter-base starter-module-runner starter-render-built-url
Description