Skip to content

Commit c1b1381

Browse files
committed
Cookies aren't controlled in browsers the same way
1 parent 2d8275a commit c1b1381

2 files changed

Lines changed: 37 additions & 36 deletions

File tree

test/node/redirects.js

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,43 @@ const request = require("../../");
77

88
describe("request", () => {
99
describe("on redirect", () => {
10+
11+
it('should merge cookies if agent is used', function(done){
12+
request
13+
.agent()
14+
.get(base + '/cookie-redirect')
15+
.set('Cookie', 'orig=1; replaced=not')
16+
.end(function(err, res){
17+
try {
18+
assert.ifError(err);
19+
assert(/orig=1/.test(res.text), "orig=1/.test");
20+
assert(/replaced=yes/.test(res.text), "replaced=yes/.test");
21+
assert(/from-redir=1/.test(res.text), "from-redir=1");
22+
done();
23+
} catch(err) {
24+
done(err);
25+
}
26+
});
27+
})
28+
29+
it('should not merge cookies if agent is not used', function(done){
30+
request
31+
.get(base + '/cookie-redirect')
32+
.set('Cookie', 'orig=1; replaced=not')
33+
.end(function(err, res){
34+
try {
35+
assert.ifError(err);
36+
assert(/orig=1/.test(res.text), "/orig=1");
37+
assert(/replaced=not/.test(res.text), "/replaced=not");
38+
assert(!/replaced=yes/.test(res.text), "!/replaced=yes");
39+
assert(!/from-redir/.test(res.text), "!/from-redir");
40+
done();
41+
} catch(err) {
42+
done(err);
43+
}
44+
});
45+
})
46+
1047
it("should follow Location", done => {
1148
const redirects = [];
1249

test/redirects.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -23,42 +23,6 @@ describe('request', function(){
2323
});
2424
})
2525

26-
it('should merge cookies if agent is used', function(done){
27-
request
28-
.agent()
29-
.get(base + '/cookie-redirect')
30-
.set('Cookie', 'orig=1; replaced=not')
31-
.end(function(err, res){
32-
try {
33-
assert.ifError(err);
34-
assert(/orig=1/.test(res.text));
35-
assert(/replaced=yes/.test(res.text));
36-
assert(/from-redir=1/.test(res.text));
37-
done();
38-
} catch(err) {
39-
done(err);
40-
}
41-
});
42-
})
43-
44-
it('should not merge cookies if agent is not used', function(done){
45-
request
46-
.get(base + '/cookie-redirect')
47-
.set('Cookie', 'orig=1; replaced=not')
48-
.end(function(err, res){
49-
try {
50-
assert.ifError(err);
51-
assert(/orig=1/.test(res.text));
52-
assert(/replaced=not/.test(res.text));
53-
assert(!/replaced=yes/.test(res.text));
54-
assert(!/from-redir/.test(res.text));
55-
done();
56-
} catch(err) {
57-
done(err);
58-
}
59-
});
60-
})
61-
6226
it('should preserve timeout across redirects', function(done){
6327
request
6428
.get(base + '/movies/random')

0 commit comments

Comments
 (0)