Remove missing fields validation for composite types

See: graphql/graphql-spec#606

Author: Victor Andrée

src/type/__tests__/validation-test.js

@@ -407,32 +407,23 @@ describe('Type System: Objects must have fields', () => {
     expect(validateSchema(schema)).to.deep.equal([]);
   });
 
-  it('rejects an Object type with missing fields', () => {
+  it('accepts an Object type with missing fields', () => {
     const schema = buildSchema(`
       type Query {
         test: IncompleteObject
       }
 
       type IncompleteObject
     `);
-    expect(validateSchema(schema)).to.deep.equal([
-      {
-        message: 'Type IncompleteObject must define one or more fields.',
-        locations: [{ line: 6, column: 7 }],
-      },
-    ]);
+    expect(validateSchema(schema)).to.deep.equal([]);
 
     const manualSchema = schemaWithFieldType(
       new GraphQLObjectType({
         name: 'IncompleteObject',
         fields: {},
       }),
     );
-    expect(validateSchema(manualSchema)).to.deep.equal([
-      {
-        message: 'Type IncompleteObject must define one or more fields.',
-      },
-    ]);
+    expect(validateSchema(manualSchema)).to.deep.equal([]);
 
     const manualSchema2 = schemaWithFieldType(
       new GraphQLObjectType({
@@ -442,11 +433,7 @@ describe('Type System: Objects must have fields', () => {
         },
       }),
     );
-    expect(validateSchema(manualSchema2)).to.deep.equal([
-      {
-        message: 'Type IncompleteObject must define one or more fields.',
-      },
-    ]);
+    expect(validateSchema(manualSchema2)).to.deep.equal([]);
   });
 
   it('rejects an Object type with incorrectly named fields', () => {
@@ -707,7 +694,7 @@ describe('Type System: Input Objects must have fields', () => {
     expect(validateSchema(schema)).to.deep.equal([]);
   });
 
-  it('rejects an Input Object type with missing fields', () => {
+  it('accepts an Input Object type with missing fields', () => {
     let schema = buildSchema(`
       type Query {
         field(arg: SomeInputObject): String
@@ -725,13 +712,7 @@ describe('Type System: Input Objects must have fields', () => {
       `),
     );
 
-    expect(validateSchema(schema)).to.deep.equal([
-      {
-        message:
-          'Input Object type SomeInputObject must define one or more fields.',
-        locations: [{ line: 6, column: 7 }, { line: 4, column: 9 }],
-      },
-    ]);
+    expect(validateSchema(schema)).to.deep.equal([]);
   });
 
   it('accepts an Input Object with breakable circular reference', () => {

src/type/validate.js

@@ -267,14 +267,6 @@ function validateFields(
 ): void {
   const fields = objectValues(type.getFields());
 
-  // Objects and Interfaces both must define one or more fields.
-  if (fields.length === 0) {
-    context.reportError(
-      `Type ${type.name} must define one or more fields.`,
-      getAllNodes(type),
-    );
-  }
-
   for (const field of fields) {
     // Ensure they are named correctly.
     validateName(context, field);
@@ -494,13 +486,6 @@ function validateInputFields(
 ): void {
   const fields = objectValues(inputObj.getFields());
 
-  if (fields.length === 0) {
-    context.reportError(
-      `Input Object type ${inputObj.name} must define one or more fields.`,
-      getAllNodes(inputObj),
-    );
-  }
-
   // Ensure the arguments are valid
   for (const field of fields) {
     // Ensure they are named correctly.