Skip to content

Commit 8a0bd8b

Browse files
authored
ci: Stop VS Code publish from blocking release PR (#12763)
## Summary - Let release PR creation proceed after npm publish and tag creation even when VS Code extension publishing fails. - Prevent failed VS Code publishing from triggering cleanup of already-published npm release state. - Document that Marketplace publishing is non-blocking for release PR recovery. ## Testing - `pnpm exec oxfmt --check .github/workflows/turborepo-release.yml AGENTS.md` - YAML parse check for `.github/workflows/turborepo-release.yml` - DevOps review agent: no findings
1 parent 20fa5c8 commit 8a0bd8b

2 files changed

Lines changed: 4 additions & 13 deletions

File tree

.github/workflows/turborepo-release.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
# 4. Publish JS packages to npm and the VS Code extension as parallel worksets
99
# 5. Create the git tag (only after npm publish succeeds)
1010
# 6. Alias versioned docs (e.g., v2-5-4.turborepo.dev)
11-
# 7. Create a release branch and open a PR
11+
# 7. Create a release branch and open a PR, even if VS Code publishing fails
1212
# 8. On failure, cleanup the staging branch and release tag automatically
1313
#
1414
# Canary releases run on an hourly schedule.
@@ -618,15 +618,8 @@ jobs:
618618

619619
create-release-pr:
620620
name: "Create Release PR"
621-
needs:
622-
[
623-
stage,
624-
npm-publish,
625-
create-release-tag,
626-
publish-vscode-extension,
627-
alias-versioned-docs
628-
]
629-
if: ${{ always() && needs.npm-publish.result == 'success' && needs.create-release-tag.result == 'success' && needs.publish-vscode-extension.result == 'success' && !inputs.dry_run }}
621+
needs: [stage, npm-publish, create-release-tag, alias-versioned-docs]
622+
if: ${{ always() && needs.npm-publish.result == 'success' && needs.create-release-tag.result == 'success' && !inputs.dry_run }}
630623
runs-on: ubuntu-24.04
631624
timeout-minutes: 30
632625
permissions:
@@ -750,7 +743,6 @@ jobs:
750743
js-smoke-test,
751744
npm-publish,
752745
create-release-tag,
753-
publish-vscode-extension,
754746
create-release-pr
755747
]
756748
if: >-
@@ -762,7 +754,6 @@ jobs:
762754
|| needs.js-smoke-test.result == 'failure'
763755
|| needs.npm-publish.result == 'failure'
764756
|| needs.create-release-tag.result == 'failure'
765-
|| needs.publish-vscode-extension.result == 'failure'
766757
|| needs.create-release-pr.result == 'failure'
767758
)
768759
}}

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,4 @@ docs: Update installation instructions
5555

5656
- The `LSP` workflow packages `packages/turbo-vsc` VSIX artifacts for release. Stable and canary Turborepo versions are mapped to Marketplace-safe `major.minor.patch` versions before packaging.
5757
- Canary VS Code extension packages use `--pre-release`.
58-
- Non-dry-run releases publish the VS Code extension through the `LSP` workflow using `publish=true`, `dry_run=false`, and a `VSCE_PAT` secret on the protected `vscode-marketplace` environment.
58+
- Non-dry-run releases publish the VS Code extension through the `LSP` workflow using `publish=true`, `dry_run=false`, and a `VSCE_PAT` secret on the protected `vscode-marketplace` environment. This publish path must not block release PR creation or cleanup published npm release state.

0 commit comments

Comments
 (0)