fix: address code review feedback (Vonage domain, from formatting, test coverage)

Author: bhardwajparth51

src/Utopia/Messaging/Adapter/SMS/VonageMessages.php

@@ -26,9 +26,7 @@ class VonageMessages extends SMSAdapter
      * @param  string  $apiSecret Vonage API Secret
      */
     public function __construct(
-        /** @phpstan-ignore property.onlyWritten */
         private string $apiKey,
-        /** @phpstan-ignore property.onlyWritten */
         private string $apiSecret,
         private ?string $from = null
     ) {
@@ -54,6 +52,13 @@ protected function process(SMSMessage $message): array
 
         $response = new Response($this->getType());
 
+        if (empty($from)) {
+            $response->addResult($message->getTo()[0], 'The "from" field is required for the Vonage Messages API.');
+            return $response->toArray();
+        }
+
+        $from = \ltrim($from, '+');
+
         $result = $this->request(
             method: 'POST',
             url: $this->getApiEndpoint(),

src/Utopia/Messaging/Adapter/VonageMessagesBase.php

@@ -21,9 +21,12 @@ trait VonageMessagesBase
      */
     protected function getApiEndpoint(): string
     {
-        return 'https://api.nexmo.com/v1/messages';
+        return 'https://api.vonage.com/v1/messages';
     }
 
+    /**
+     * @todo Implement JWT authentication for non-SMS channels
+     */
     protected function getAuthorizationHeader(): string
     {
         return 'Basic ' . \base64_encode("{$this->apiKey}:{$this->apiSecret}");

tests/Messaging/Adapter/SMS/VonageMessagesTest.php

@@ -15,9 +15,10 @@ public function testSendSMS(): void
     {
         $apiKey = \getenv('VONAGE_API_KEY');
         $apiSecret = \getenv('VONAGE_API_SECRET');
+        $to = \getenv('VONAGE_TO');
 
-        if (!$apiKey || !$apiSecret) {
-            $this->markTestSkipped('Vonage Messages credentials are not available.');
+        if (!$apiKey || !$apiSecret || !$to) {
+            $this->markTestSkipped('Vonage Messages credentials or recipient are not available.');
         }
 
         $sender = new VonageMessages(
@@ -27,7 +28,7 @@ public function testSendSMS(): void
         );
 
         $message = new SMS(
-            to: [\getenv('VONAGE_TO')],
+            to: [$to],
             content: 'Test Content',
             from: \getenv('VONAGE_FROM')
         );
@@ -36,4 +37,34 @@ public function testSendSMS(): void
 
         $this->assertResponse($response);
     }
+
+    /**
+     * @throws \Exception
+     */
+    public function testSendSMSWithFallbackFrom(): void
+    {
+        $apiKey = \getenv('VONAGE_API_KEY');
+        $apiSecret = \getenv('VONAGE_API_SECRET');
+        $to = \getenv('VONAGE_TO');
+        $from = \getenv('VONAGE_FROM');
+
+        if (!$apiKey || !$apiSecret || !$to || !$from) {
+            $this->markTestSkipped('Vonage Messages credentials or sender/recipient are not available.');
+        }
+
+        $sender = new VonageMessages(
+            apiKey: $apiKey,
+            apiSecret: $apiSecret,
+        );
+
+        $message = new SMS(
+            to: [$to],
+            content: 'Test Content',
+            from: $from
+        );
+
+        $response = $sender->send($message);
+
+        $this->assertResponse($response);
+    }
 }