fix: strip querystrings and hash fragments when checking for file existence (#479)

Co-authored-by: JounQin <admin@1stg.me>
Signed-off-by: JounQin <admin@1stg.me>

Author: mrginglymus

.changeset/khaki-lemons-divide.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix: strip querystrings and hash fragments when checking for file existence

src/utils/resolve.ts

@@ -71,9 +71,11 @@ export function fileExistsWithCaseSync(
   if (filepath === null) {
     return true
   }
+
   if (filepath.toLowerCase() === process.cwd().toLowerCase() && !strict) {
     return true
   }
+
   const parsedPath = path.parse(filepath)
   const dir = parsedPath.dir
 
@@ -88,15 +90,36 @@ export function fileExistsWithCaseSync(
   } else {
     try {
       const filenames = fs.readdirSync(dir)
-      result = filenames.includes(parsedPath.base)
-        ? fileExistsWithCaseSync(dir, cacheSettings, strict, false)
-        : !leaf &&
+      if (filenames.includes(parsedPath.base)) {
+        result = fileExistsWithCaseSync(dir, cacheSettings, strict, false)
+      } else {
+        const baseLowerCase = parsedPath.base.toLowerCase()
+        const hasCaseInsensitiveMatch = filenames.some(
+          p => p.toLowerCase() === baseLowerCase,
+        )
+
+        const isMissing = !hasCaseInsensitiveMatch
+
+        if (isMissing && leaf) {
+          const queryIndex = filepath.lastIndexOf('?')
+          const hashIndex = filepath.lastIndexOf('#')
+          const index = Math.max(queryIndex, hashIndex)
+
+          result =
+            index > 0
+              ? fileExistsWithCaseSync(
+                  filepath.slice(0, index),
+                  cacheSettings,
+                  strict,
+                )
+              : false
+        } else {
           // We tolerate case-insensitive matches if there are no case-insensitive matches.
           // It'll fail anyway on the leaf node if the file truly doesn't exist (if it doesn't
           // fail it's that we're probably working with a virtual in-memory filesystem).
-          !filenames.some(
-            p => p.toLowerCase() === parsedPath.base.toLowerCase(),
-          )
+          result = isMissing && !leaf
+        }
+      }
     } catch (error) {
       if (isDirectoryAccessError(error)) {
         result = true

test/rules/no-unresolved.spec.ts

@@ -48,6 +48,11 @@ function runResolverTests(resolver: 'node' | 'webpack') {
       }),
 
       tValid({ code: 'import foo from "./bar";' }),
+      tValid({ code: 'import foo from "./bar?qs";' }),
+      ...(resolver === 'node'
+        ? [tValid({ code: 'import foo from "./bar#hash";' })]
+        : []),
+      tValid({ code: 'import foo from "./bar?qs#hash";' }),
       tValid({ code: "import bar from './bar.js';" }),
       tValid({ code: "import {someThing} from './test-module';" }),
       tValid({ code: "import fs from 'fs';" }),

test/utils/resolve.spec.ts

@@ -477,6 +477,13 @@ describe('resolve', () => {
       expect(fileExistsWithCaseSync(file, cacheSettings)).toBe(false)
     })
 
+    it.each(['?qs', '#hash', '?qs#hash'])(
+      'falls back from %s when detecting case mismatch',
+      suffix => {
+        expect(fileExistsWithCaseSync(file + suffix, cacheSettings)).toBe(false)
+      },
+    )
+
     it('detecting case does not include parent folder path (issue #720)', () => {
       const f = path.resolve(
         process.cwd().toUpperCase(),