Fix editor viewport placement and recent file tracking

Keep editor viewports on the frame selected when placement starts and use a deterministic fallback order: below, right, left, then replace. Attempt below placement only when the source has at least 24 lines, target a 12-line viewport, accept an 8-line minimum, and accept side placement only when both the source and viewport remain at least 24 columns wide.

Split side-window sessions directly into normal viewport windows so all four side positions follow the same fallback policy without creating same-side siblings. Roll back failed attempts, preserve restoration after layout transposition, and keep frame-producing display actions out of the controlled chain.

Exclude external-editor staging files from recentf without changing user configuration. Cover dimension boundaries, normal and side-window geometry, fallback ordering, selected-frame isolation, no-frame behavior, layout transposition, restoration, cancel/save flows, and recentf bindings. Keep the transpose checks compatible with the minimum supported Emacs by exercising window-x only when it is available.

Author: cxa

ai-code-editor-viewport-transport.el

@@ -16,7 +16,8 @@
 (require 'subr-x)
 
 (declare-function ai-code-editor-viewport--open-request
-                  "ai-code-editor-viewport" (source-buffer payload))
+                  "ai-code-editor-viewport"
+                  (source-buffer payload &optional origin-frame))
 (declare-function ai-code-editor-viewport--schedule-submit
                   "ai-code-editor-viewport" (source-buffer))
 
@@ -43,6 +44,10 @@
 (defconst ai-code-editor-viewport--submit-ready-prefix "submit-ready:"
   "Prefix for completion payloads emitted after a helper is reaped.")
 
+(defconst ai-code-editor-viewport--request-version
+  "ai-code-editor-viewport-v1"
+  "Version marker for editor request payloads with explicit request kinds.")
+
 (defconst ai-code-editor-viewport--frame-prefix-environment-variable
   "AI_CODE_EDITOR_VIEWPORT_FRAME_PREFIX"
   "Environment variable containing the helper's terminal frame prefix.")
@@ -178,9 +183,10 @@ When TOKEN is nil, discard any pending token."
     (if (string-prefix-p ai-code-editor-viewport--submit-ready-prefix payload)
         (ai-code-editor-viewport--consume-submit-ready source-buffer payload)
       (ai-code-editor-viewport--discard-submit-token source-buffer)
-      (run-at-time 0 nil
-                   #'ai-code-editor-viewport--open-request
-                   source-buffer payload)
+      (let ((origin-frame (selected-frame)))
+        (run-at-time 0 nil
+                     #'ai-code-editor-viewport--open-request
+                     source-buffer payload origin-frame))
       t)))
 
 (defun ai-code-editor-viewport-filter-output (process output)
@@ -225,6 +231,9 @@ STATUS-DIRECTORY is where the helper creates its response files."
                                temporary-file-directory))))
     (concat
      "#!/bin/sh\n"
+     "request_kind=regular\n"
+     "[ \"${1-}\" = \"--ai-code-staging\" ]"
+     " && request_kind=staging && shift\n"
      "submit=0\n"
      "[ \"${1-}\" = \"--ai-code-submit\" ] && submit=1 && shift\n"
      "[ \"$#\" -gt 0 ] || exit 1\n"
@@ -239,6 +248,10 @@ STATUS-DIRECTORY is where the helper creates its response files."
      "    printf '%s\\0' \"$status_file\"\n"
      "    printf '%s\\0' \"${PWD-}\"\n"
      "    printf '%s\\0' \"$submit\"\n"
+     "    printf '%s\\0' \""
+     ai-code-editor-viewport--request-version
+     "\"\n"
+     "    printf '%s\\0' \"$request_kind\"\n"
      "    printf '%s\\0' \"$@\"\n"
      "  } | base64 | tr -d '\\r\\n'\n"
      ") || exit 1\n"
@@ -341,17 +354,18 @@ STATUS-DIRECTORY is where the helper creates its response files."
   "Return ENVIRONMENT configured to edit through a terminal viewport.
 FRAME-PREFIX, when non-nil, selects an adapter-specific terminal frame.
 General editor requests submit restored input when
-`ai-code-editor-viewport-auto-submit' is non-nil.  Git editor requests only
-save."
+`ai-code-editor-viewport-auto-submit' is non-nil.  They are marked as staging
+requests independently of submission.  Git editor requests only save."
   (if (or (not ai-code-editor-viewport-enabled)
           (not (ai-code-editor-viewport--supported-p)))
       environment
     (let* ((helper (ai-code-editor-viewport--ensure-helper))
            (helper-command (shell-quote-argument helper))
-           (submit-command (concat helper-command " --ai-code-submit"))
+           (staging-command (concat helper-command " --ai-code-staging"))
+           (submit-command (concat staging-command " --ai-code-submit"))
            (editor-command (if ai-code-editor-viewport-auto-submit
                                submit-command
-                             helper-command))
+                             staging-command))
            (prefix (or frame-prefix
                        (ai-code-editor-viewport--frame-prefix))))
       (append