Skip to content

Commit eedf3dc

Browse files
gitdallasTitani
authored andcommitted
fix(ClipboardCopy): remove popoverposition (patternfly#8226)
* fix(ClipboardCopy): remove popoverposition * edit doc comment * remove popover type from clipboardcopybutton
1 parent 5e2813e commit eedf3dc

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

packages/react-core/src/components/ClipboardCopy/ClipboardCopy.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as React from 'react';
22
import styles from '@patternfly/react-styles/css/components/ClipboardCopy/clipboard-copy';
33
import { css } from '@patternfly/react-styles';
44
import { PickOptional } from '../../helpers/typeUtils';
5-
import { PopoverPosition } from '../Popover';
65
import { TooltipPosition } from '../Tooltip';
76
import { TextInput } from '../TextInput';
87
import { GenerateId } from '../../helpers/GenerateId/GenerateId';
@@ -53,9 +52,8 @@ export interface ClipboardCopyProps extends Omit<React.HTMLProps<HTMLDivElement>
5352
isBlock?: boolean;
5453
/** Adds Clipboard Copy variant styles. */
5554
variant?: typeof ClipboardCopyVariant | 'inline' | 'expansion' | 'inline-compact';
56-
/** Copy button popover position. */
55+
/** Copy button tooltip position. */
5756
position?:
58-
| PopoverPosition
5957
| TooltipPosition
6058
| 'auto'
6159
| 'top'
@@ -109,7 +107,7 @@ export class ClipboardCopy extends React.Component<ClipboardCopyProps, Clipboard
109107
isExpanded: false,
110108
isCode: false,
111109
variant: 'inline',
112-
position: PopoverPosition.top,
110+
position: TooltipPosition.top,
113111
maxWidth: '150px',
114112
exitDelay: 1600,
115113
entryDelay: 300,

packages/react-core/src/components/ClipboardCopy/ClipboardCopyButton.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as React from 'react';
22
import CopyIcon from '@patternfly/react-icons/dist/esm/icons/copy-icon';
33
import { Button } from '../Button';
44
import { Tooltip, TooltipPosition } from '../Tooltip';
5-
import { PopoverPosition } from '../Popover';
65

76
export interface ClipboardCopyButtonProps
87
extends Omit<React.DetailedHTMLProps<React.ButtonHTMLAttributes<HTMLButtonElement>, HTMLButtonElement>, 'ref'> {
@@ -25,7 +24,6 @@ export interface ClipboardCopyButtonProps
2524
/** Position of the copy button tooltip */
2625
position?:
2726
| TooltipPosition
28-
| PopoverPosition
2927
| 'auto'
3028
| 'top'
3129
| 'bottom'

0 commit comments

Comments
 (0)