Skip to content

Commit 133089f

Browse files
andyyvoTitani
authored andcommitted
fix(Page): updated onPageResize prop to undefined default (patternfly#8203)
1 parent f6a0b42 commit 133089f

2 files changed

Lines changed: 13 additions & 14 deletions

File tree

packages/react-core/src/components/Page/Page.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export class Page extends React.Component<PageProps, PageState> {
101101
isManagedSidebar: false,
102102
isBreadcrumbWidthLimited: false,
103103
defaultManagedSidebarIsOpen: true,
104-
onPageResize: (): void => null,
105104
mainTabIndex: -1,
106105
isNotificationDrawerExpanded: false,
107106
onNotificationDrawerExpand: () => null,

packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ exports[`Page Check dark page against snapshot 1`] = `
44
<DocumentFragment>
55
<div
66
aria-label="Page layout"
7-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
7+
class="pf-c-page my-page-class"
88
id="PageId"
99
>
1010
<header
@@ -65,7 +65,7 @@ exports[`Page Check page horizontal layout example against snapshot 1`] = `
6565
<DocumentFragment>
6666
<div
6767
aria-label="Page layout"
68-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
68+
class="pf-c-page my-page-class"
6969
id="PageId"
7070
>
7171
<header
@@ -129,7 +129,7 @@ exports[`Page Check page to verify breadcrumb is created - PageBreadcrumb syntax
129129
<DocumentFragment>
130130
<div
131131
aria-label="Page layout"
132-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
132+
class="pf-c-page my-page-class"
133133
id="PageId"
134134
>
135135
<header
@@ -296,7 +296,7 @@ exports[`Page Check page to verify breadcrumb is created 1`] = `
296296
<DocumentFragment>
297297
<div
298298
aria-label="Page layout"
299-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
299+
class="pf-c-page my-page-class"
300300
id="PageId"
301301
>
302302
<header
@@ -463,7 +463,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - new components s
463463
<DocumentFragment>
464464
<div
465465
aria-label="Page layout"
466-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
466+
class="pf-c-page my-page-class"
467467
id="PageId"
468468
>
469469
<header
@@ -749,7 +749,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - old / props synt
749749
<DocumentFragment>
750750
<div
751751
aria-label="Page layout"
752-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
752+
class="pf-c-page my-page-class"
753753
id="PageId"
754754
>
755755
<header
@@ -1040,7 +1040,7 @@ exports[`Page Check page to verify nav is created - PageNavigation syntax 1`] =
10401040
<DocumentFragment>
10411041
<div
10421042
aria-label="Page layout"
1043-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1043+
class="pf-c-page my-page-class"
10441044
id="PageId"
10451045
>
10461046
<header
@@ -1219,7 +1219,7 @@ exports[`Page Check page to verify skip to content points to main content region
12191219
<DocumentFragment>
12201220
<div
12211221
aria-label="Page layout"
1222-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1222+
class="pf-c-page my-page-class"
12231223
data-testid="page-test-id"
12241224
id="PageId"
12251225
>
@@ -1394,7 +1394,7 @@ exports[`Page Check page vertical layout example against snapshot 1`] = `
13941394
<DocumentFragment>
13951395
<div
13961396
aria-label="Page layout"
1397-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1397+
class="pf-c-page my-page-class"
13981398
id="PageId"
13991399
>
14001400
<header
@@ -1455,7 +1455,7 @@ exports[`Page Sticky bottom breadcrumb on all height breakpoints - PageBreadcrum
14551455
<DocumentFragment>
14561456
<div
14571457
aria-label="Page layout"
1458-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1458+
class="pf-c-page my-page-class"
14591459
id="PageId"
14601460
>
14611461
<header
@@ -1622,7 +1622,7 @@ exports[`Page Verify sticky bottom breadcrumb on all height breakpoints 1`] = `
16221622
<DocumentFragment>
16231623
<div
16241624
aria-label="Page layout"
1625-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1625+
class="pf-c-page my-page-class"
16261626
id="PageId"
16271627
>
16281628
<header
@@ -1789,7 +1789,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints - PageBread
17891789
<DocumentFragment>
17901790
<div
17911791
aria-label="Page layout"
1792-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1792+
class="pf-c-page my-page-class"
17931793
id="PageId"
17941794
>
17951795
<header
@@ -1956,7 +1956,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints 1`] = `
19561956
<DocumentFragment>
19571957
<div
19581958
aria-label="Page layout"
1959-
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
1959+
class="pf-c-page my-page-class"
19601960
id="PageId"
19611961
>
19621962
<header

0 commit comments

Comments
 (0)