correctly update name attribute of vault_identity_entity_alias resources

[jcarrothers-sap]

• fixed updates to the name of an entity-alias
• added an update test to ensure all attributes of an entity-alias are updated

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

correctly update name attribute of vault_identity_entity_alias resources

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIdentityEntityAlias -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    0.019s [no tests to run]
=== RUN   TestAccIdentityEntityAlias
--- PASS: TestAccIdentityEntityAlias (0.34s)
=== RUN   TestAccIdentityEntityAlias_Update
--- PASS: TestAccIdentityEntityAlias_Update (0.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   (cached)

[jcarrothers-sap]

I'm not sure why the build failed for this PR, but it does not appear to have anything to do with this change.

[tyrannosaurus-becks]

Great catch! Thanks for fixing this!