Skip to content

Add support for configuring the Transit cache - #548

Merged
kalafut merged 3 commits into
masterfrom
transit-cache-config
Oct 2, 2019
Merged

Add support for configuring the Transit cache#548
kalafut merged 3 commits into
masterfrom
transit-cache-config

Conversation

@kalafut

@kalafut kalafut commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread website/docs/r/transit_secret_backend_cache_config.html.md Outdated

@catsby catsby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/questions I'd like to hear back on, nothing major

Comment thread website/docs/r/transit_secret_backend_cache_config.html.md
Comment thread vault/resource_transit_cache_config.go Outdated
Comment thread vault/resource_transit_cache_config.go Outdated
Comment thread vault/resource_transit_cache_config.go
@kalafut

kalafut commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

@catsby Added the StateFunc like we discussed.

@catsby catsby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kalafut
kalafut merged commit 3008895 into master Oct 2, 2019
@kalafut
kalafut deleted the transit-cache-config branch October 2, 2019 16:10
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants