Add root_rotation_statements to vault_database_secret_backend_connection - #530
Merged
Merged
Conversation
ghost
added
the
tyrannosaurus-becks
left a comment
tyrannosaurus-becks
left a comment
Contributor
There was a problem hiding this comment.
Hi! Thanks for working on this, it's much appreciated! Per the contributing doc, it just needs one more thing, a related docs update, then it'll be good to go!
Contributor
Author
|
Sure, added! |
tyrannosaurus-becks
approved these changes
Oct 9, 2019
tyrannosaurus-becks
left a comment
tyrannosaurus-becks
left a comment
Contributor
There was a problem hiding this comment.
Fantastic! Thank you!
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Add root_rotation_statements to vault_database_secret_backend_connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527