Skip to content

Add support for response-wrapping AppRole secret IDs - #518

Merged
kalafut merged 2 commits into
masterfrom
approle-wrap-ttl
Aug 28, 2019
Merged

Add support for response-wrapping AppRole secret IDs#518
kalafut merged 2 commits into
masterfrom
approle-wrap-ttl

Conversation

@kalafut

@kalafut kalafut commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@catsby catsby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , 1 nit-pick

Comment thread vault/resource_approle_auth_backend_role_secret_id.go

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, @kalafut ! I also approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants