Add Azure Secret Backend resource - #481
Merged
tyrannosaurus-becks merged 1 commit intoAug 5, 2019
Merged
Conversation
ghost
added
petems
force-pushed
the
add_vault_azure_secret_backend
branch
2 times, most recently
from
August 2, 2019 20:35
c7dca36 to
529aa97
Compare
tyrannosaurus-becks
left a comment
tyrannosaurus-becks
left a comment
Contributor
There was a problem hiding this comment.
This looks very good! Just a couple of questions. Also, one more request, would you be willing to merge in master and push it up just to see the tests passing?
Thanks again!
petems
force-pushed
the
add_vault_azure_secret_backend
branch
from
August 5, 2019 17:30
2fd0247 to
0b41011
Compare
tyrannosaurus-becks
approved these changes
Aug 5, 2019
tyrannosaurus-becks
left a comment
tyrannosaurus-becks
left a comment
Contributor
There was a problem hiding this comment.
Superb! Thank you!
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…ackend Add Azure Secret Backend resource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the two! (See #460)