Update tests, add import for auth backends. - #12
Conversation
Auth backends now use the path as the ID, not the name. This will allow us to have multiple of the same auth backend mounted on the same vault server. It will also allow us to match the auth backend using just the path, instead of the path and the type combination. This is largely necessary for import, where we only have the ID, so we need the ID to be able to uniquely identify the resource, which the type can't do, but the path can. We also updated the initial test to randomise the path the auth backend is mounted at, instead of mounting it at a static path, which makes tests more resilient and less likely to fail due to collisions. Read now sets all the fields in state.
|
I'm almost positive I need to do a state migration to account for the change in the ID. |
We're using helper/acctest now, so it needs to be vendored.
|
I think you're right about a state migration being needed here. That alone doesn't make this a breaking change though, since state migrations happen automatically without any user interaction. Perhaps you meant something else as the breaking change here? |
|
Yeah, anyone that uses Granted, that is a pretty small breaking change, but figured it was worth calling out in the CHANGELOG anyways. |
|
Ahh yes, that's correct. I expected that people would use |
Add a migration that changes our auth backend ID for us, and a test to ensure it's working correctly.
|
Updated with the migration and the test for the migration, this should be ready to go now. |
Left a var out of a Fatalf, that's embarrassing.
…ackend_import Update tests, add import for auth backends.
2 participants
Auth backends now use the path as the ID, not the name. This will allow
us to have multiple of the same auth backend mounted on the same vault
server. It will also allow us to match the auth backend using just the
path, instead of the path and the type combination.
This is largely necessary for import, where we only have the ID, so we
need the ID to be able to uniquely identify the resource, which the type
can't do, but the path can.
We also updated the initial test to randomise the path the auth backend
is mounted at, instead of mounting it at a static path, which makes
tests more resilient and less likely to fail due to collisions.
Read now sets all the fields in state.