Skip to content

Commit 5e0865f

Browse files
committed
refactor: update e2e tests to use cached settings for improved performance
1 parent 78c1890 commit 5e0865f

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

apps/nestjs-backend/test/auth.e2e-spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import type {
1313
IGetTempTokenVo,
1414
ITableFullVo,
1515
IUserMeVo,
16+
ISettingVo,
1617
} from '@teable/openapi';
1718
import {
1819
ADD_PIN,
@@ -55,6 +56,7 @@ describe('Auth Controller (e2e)', () => {
5556
let app: INestApplication;
5657
let prismaService: PrismaService;
5758
let settingService: SettingService;
59+
let originalGetSetting: ISettingVo;
5860

5961
const authTestEmail = 'auth@test-auth.com';
6062

@@ -67,6 +69,7 @@ describe('Auth Controller (e2e)', () => {
6769
app = appCtx.app;
6870
prismaService = app.get(PrismaService);
6971
settingService = app.get(SettingService);
72+
originalGetSetting = await settingService.getSetting();
7073
});
7174

7275
afterAll(async () => {
@@ -136,10 +139,9 @@ describe('Auth Controller (e2e)', () => {
136139

137140
describe('sign up with email verification', () => {
138141
beforeEach(async () => {
139-
const originalGetSetting = settingService.getSetting.bind(settingService);
140142
vi.spyOn(settingService, 'getSetting').mockImplementation(async () => {
141143
return {
142-
...(await originalGetSetting()),
144+
...originalGetSetting,
143145
enableEmailVerification: true,
144146
};
145147
});

apps/nestjs-backend/test/waitlist.e2e-spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ describe('Auth Controller (e2e) api/auth waitlist', () => {
2121
app = appCtx.app;
2222
prismaService = app.get(PrismaService);
2323
settingService = app.get(SettingService);
24-
const originalGetSetting = settingService.getSetting.bind(settingService);
24+
const originalGetSetting = await settingService.getSetting();
2525
vi.spyOn(settingService, 'getSetting').mockImplementation(async () => {
2626
return {
27-
...(await originalGetSetting()),
27+
...originalGetSetting,
2828
enableWaitlist: true,
2929
};
3030
});

0 commit comments

Comments
 (0)